-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
copy-paste error in NIOTSConnectionChannel getOption0 allowLocalEndpointReuse #133
Comments
Good catch! Even if it’s not working well, we’d take a fix to make it correct here. |
It looks like a similar issue slipped through in
It won't make any difference as long as both |
Agreed. Do you feel like making a patch? |
Sure, I'll submit a PR when I get a chance. |
Looks like a copy-paste mistake here:
swift-nio-transport-services/Sources/NIOTransportServices/NIOTSConnectionChannel.swift
Lines 320 to 323 in e7f5278
allowLocalEndpointReuse
is being set to the value ofNIOTSEnablePeerToPeerOption
, not itself.Though it might not really matter, because from everything I can tell
allowLocalEndpointReuse
seems to be completely broken on NWListener (ref https://developer.apple.com/forums/thread/129452).The text was updated successfully, but these errors were encountered: