Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NIOFilterEmptyWritesHandler isn't guarded by if #canImport(Network) #110

Open
glbrntt opened this issue Jan 15, 2021 · 1 comment
Open

NIOFilterEmptyWritesHandler isn't guarded by if #canImport(Network) #110

glbrntt opened this issue Jan 15, 2021 · 1 comment
Labels
⚠️ semver/major Breaks existing public API.

Comments

@glbrntt
Copy link
Contributor

glbrntt commented Jan 15, 2021

All of the code in NIOTS should be guarded by if #canImport(Network). However NIOFilterEmptyWritesHandler isn't. Since its intended use is to work around a bug in Network framework, it's only helpful when Network framework is available anyway.

We can't add the check now as it would break API, but we should consider adding the missing compilation check for the next major version of NIOTS.
@glbrntt glbrntt changed the title NIOFilterEmptyWritesHandler isn't guarded by #canImport(Network) NIOFilterEmptyWritesHandler isn't guarded by if #canImport(Network) Jan 15, 2021
@glbrntt glbrntt added the ⚠️ semver/major Breaks existing public API. label Jan 15, 2021
@weissi
Copy link
Member

weissi commented Jan 15, 2021

The bug is fixed too, so another option is to remove it entirely :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
⚠️ semver/major Breaks existing public API.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@weissi @glbrntt