-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support keyboard-interactive authentication #136
Comments
We can absolutely add support for keyboard-interactive authentication. We should implement both sides of the flow, but we don't need to actually have the server do anything so long as it can defer the implementation to the delegate that already exists. |
I'm trying to implement keyboard-interactive authentication, but there are some troubles I met code here case SSHMessage.UserAuthPKOKMessage.id:
guard let message = try self.readUserAuthPKOKMessage() else {
return nil
}
return .userAuthPKOK(message) what I'm trying is to add code here case SSHMessage.UserAuthInfoRequestMessage.id:
guard let message = try self.readUserAuthInfoRequestMessage() else {
return nil
}
return .userAuthInfoRequest(message) of course UserAuthPKOKMessage will take care of the flow instead of UserAuthInfoRequestMessage, so there is a conflict need to be solved which will cause a major code modification |
Yeah, this will require a substantial chunk of work. It will be necessary to pass some context information into the parser so that it is able to tell what it is likely to be decoding. |
While implementing 2-factor login in my app, I noticed that
swift-nio-ssh
is missing support forkeyboard-interactive
authentication. I can create a pull request to add it to theNIOSSHAvailableUserAuthenticationMethods: OptionSet
and make the client recognize keyboard-interactive messages. However, I am concerned that this change may cause issues on the server-side. So I created this issue to ask if you have any plans to support keyboard-interactive authentication in the future.The text was updated successfully, but these errors were encountered: