-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type casting SObjectField to 'String' throws errors for non-string field types #495
Comments
Would love to have some feedback on this and the PR. Thanks, |
Apologies for the delay. I am DF24 and I am planning to get into this when I get back. |
😄 I had a feeling that everyone was busy with DF24. Wish I was there too! Enjoy, no worries we can talk more next week. Have a great DF24 and a nice weekend! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
In the
fflib_SObjects
class, all these methods:are type casting SObjectFields to String. This is fine for all the field types that can be casted to String. However, type casting the number types to a String as all the above methods are doing:
(String) record.get(field)
throws errors likeInvalid conversion from runtime type Integer to String
, orInvalid conversion from runtime type Decimal to String
To Reproduce
Modify the
generateDomain
method from thefflib_SObjectsTest
class to include in the Accounts theNumberOfEmployees
field with a random Integer value and then run the entire test class. The tests for all the above methods will now fail.Steps to reproduce the behavior:
fflib_SObjectsTest.cls
to include theNumberOfEmployees
field with an interger value to one or more of the new Accounts and deploy the changesSystem.TypeException: Invalid conversion from runtime type Integer to String
Expected behavior
When the above methods are called for any field no matter its type, they correctly return the promised values or records.
Screenshots and text of error observed
Example of modified
generateDomain
method:and the error for one of the existing tests (more are needed to be added to show the extent of the failures)
fflib_SObjectsTest.itShouldReturnRecordsWithAllFieldValues fflib_Objects Fail 14% System.TypeException: Invalid conversion from runtime type Integer to String Class.fflib_SObjects.getRecordsWithAllNotBlankFieldValues: line 340, column 1 Class.fflib_SObjectsTest.DomainAccounts.selectPopulatedRecords: line 343, column 1 Class.fflib_SObjectsTest.itShouldReturnRecordsWithAllFieldValues: line 141, column 1 8
Version
Did you try to reproduce the problem against the latest fflib-apex-common code?
Yes,
The text was updated successfully, but these errors were encountered: