Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn and handle if AMS messages are > 1 MB #156

Open
tofu-rocketry opened this issue Mar 24, 2021 · 3 comments · May be fixed by #179
Open

Warn and handle if AMS messages are > 1 MB #156

tofu-rocketry opened this issue Mar 24, 2021 · 3 comments · May be fixed by #179
Assignees
Milestone

Comments

@tofu-rocketry
Copy link
Member

Related to #74 as it could/should be implemented alongside that.

AMS has a limit of 1MB for messages as that is what it is optimised around. SSM should check the size of messages (and any associated wrapping) before sending them to check they won't hit this limit, and ideally handle a fail gracefully. #74 could then be used to split the message into manageable parts.

Should also consider what to do if any messages can't be sent - send what you can, or fail completely? Probably send what you can.

@tofu-rocketry
Copy link
Member Author

tofu-rocketry commented Mar 29, 2021

Somewhat duplicates #155 though with the aim or pre-empting the problem.

@tofu-rocketry
Copy link
Member Author

@jounaidr jounaidr linked a pull request Sep 13, 2021 that will close this issue
@tofu-rocketry tofu-rocketry added this to the 3.3.0 milestone Aug 4, 2022
@tofu-rocketry tofu-rocketry modified the milestones: 3.3.0, 3.5.0 Jun 12, 2023
@kreczko
Copy link

kreczko commented Oct 8, 2024

Should also consider what to do if any messages can't be sent - send what you can, or fail completely? Probably send what you can.

Is there a way to split up the messages?
Currently, this completely blocks publishing if for some reason the message exceeds this limit.
Naively I would expect the accounting records to be easily partitionable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

4 participants