Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YUNIKORN-2541] Upgrade golang.org/x/net for CVEs #177

Closed
wants to merge 1 commit into from
Closed

[YUNIKORN-2541] Upgrade golang.org/x/net for CVEs #177

wants to merge 1 commit into from

Conversation

wilfred-s
Copy link
Contributor

What is this PR for?

Update golang dependencies for CVEs

What type of PR is it?

  • - Improvement

What is the Jira issue?

How should this be tested?

NA

@wilfred-s wilfred-s self-assigned this May 9, 2024
chia7712
chia7712 approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chenyulin0719
chenyulin0719 requested changes May 9, 2024
View reviewed changes
Copy link
Contributor

@chenyulin0719 chenyulin0719 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indirect requires are changed after running 'go mod tidy'.

  • golang.org/x/sys -> v0.18.0
  • golang.org/x/term -> v0.18.0

@wilfred-s
Copy link
Contributor Author

commit updated, go mod tidy change was still sitting staged locally

chenyulin0719
chenyulin0719 approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@chenyulin0719 chenyulin0719 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

pbacsko
pbacsko approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@pbacsko pbacsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@chia7712 chia7712 closed this in aa9a293 May 13, 2024
@wilfred-s wilfred-s deleted the YUNIKRN-2541 branch September 17, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chia7712 chia7712 chia7712 approved these changes

@pbacsko pbacsko pbacsko approved these changes

@chenyulin0719 chenyulin0719 chenyulin0719 approved these changes

Assignees

@wilfred-s wilfred-s

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wilfred-s @chia7712 @pbacsko @chenyulin0719