From 565dfb041e8874e785259e221f35dc60a796938c Mon Sep 17 00:00:00 2001 From: Tamas Cservenak Date: Sat, 19 Oct 2024 10:25:19 +0200 Subject: [PATCH] [MNG-8331] Mix of the two fixes Don't do anything if not needed. --- https://issues.apache.org/jira/browse/MNG-8331 --- .../internal/impl/model/DefaultModelBuilder.java | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/maven-api-impl/src/main/java/org/apache/maven/internal/impl/model/DefaultModelBuilder.java b/maven-api-impl/src/main/java/org/apache/maven/internal/impl/model/DefaultModelBuilder.java index 38266f30327b..95cb2ea70d5d 100644 --- a/maven-api-impl/src/main/java/org/apache/maven/internal/impl/model/DefaultModelBuilder.java +++ b/maven-api-impl/src/main/java/org/apache/maven/internal/impl/model/DefaultModelBuilder.java @@ -564,8 +564,10 @@ public void mergeRepositories(List toAdd, boolean replace) { // Infer inner reactor dependencies version // Model transformFileToRaw(Model model) { - List newDeps = new ArrayList<>(); - boolean modified = false; + if (model.getDependencies().isEmpty()) { + return model; + } + List newDeps = new ArrayList<>(model.getDependencies().size()); for (Dependency dep : model.getDependencies()) { if (dep.getVersion() == null) { Dependency.Builder depBuilder = null; @@ -591,13 +593,14 @@ Model transformFileToRaw(Model model) { } if (depBuilder != null) { newDeps.add(depBuilder.build()); - modified = true; } else { newDeps.add(dep); } + } else { + newDeps.add(dep); } } - return modified ? model.withDependencies(newDeps) : model; + return model.withDependencies(newDeps); } String replaceCiFriendlyVersion(Map properties, String version) {