-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug report] UI: Some password field is still plaintext #4506
Comments
@LauraXia123 Would you like to take a look at this issue ? Thanks! |
@featherchen hi, can you help fix this issue? |
@LauraXia123 Okey, I'll take a look at it. |
@LauraXia123 @danhuawang This is a related but different issue with #4384, the latter deals with password input, and the former wants to hide password display in detail. Just hiding the password is trivial, but I think the crucial problem is if we hide it in the detail page, where can the users see their jdbc-password. |
@featherchen In the future, we will open up viewing access to those who have it. Hide it for now. |
@LauraXia123 I have hidden it in frontend via #4561, however the password is still plaintext in the http response from backend |
yeah, we can create new issue to follow it. |
### What changes were proposed in this pull request? Hide jdbc-password value in details page. ### Why are the changes needed? Fix: #4506 ### Does this PR introduce _any_ user-facing change? Jdbc-password value is not palintext now. ### How was this patch tested? ![Screenshot from 2024-08-16 15-31-53](https://github.com/user-attachments/assets/75cb2a83-8145-41be-9be5-19a7a4add336) ![Screenshot from 2024-08-16 15-21-04](https://github.com/user-attachments/assets/63e34fee-fef1-4fa6-a93c-ac028b2d04b3)
Version
main branch
Describe what's wrong
Error message and/or stacktrace
N/A
How to reproduce
Additional context
No response
The text was updated successfully, but these errors were encountered: