Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of track IO timing gpdb feature #536

Open
2 tasks done
reshke opened this issue Jul 26, 2024 · 7 comments
Open
2 tasks done

Lack of track IO timing gpdb feature #536

reshke opened this issue Jul 26, 2024 · 7 comments
Assignees

Comments

@reshke
Copy link
Contributor

reshke commented Jul 26, 2024

There is GPDB feature for tracking IO timing for AO/AOCS relations
One can refer to implementation in GPDB archive repo
greenplum-db/gpdb-archive@fc081c7

I faced some conflict when applying my Yezzey-related patches on CBDB HEAD, so I wonder whats is actual reason of absence of this feature. Is there some major bugs, or CBDB project does not include all GP 7 functionality by design?

Are you willing to submit PR?

  • Yes, I am willing to submit a PR!

Code of Conduct

@reshke reshke added the type: Bug Something isn't working label Jul 26, 2024
Copy link

Hey, @reshke welcome!🎊 Thanks for taking the time to point this out.🙌

@gfphoenix78
Copy link
Contributor

Hi @reshke , thank you for your interesting on CBDB. CBDB forked GPDB at early 2022(gp7 alpha or beta). GPDB had many commits since that time. We know the value of GPDB patches and we are porting these commits to our CBDB. We need some time to complete this work. Please continuing on focus our product, you'll see this feature in CBDB later.

@gfphoenix78 gfphoenix78 added type: Backport and removed type: Bug Something isn't working labels Jul 26, 2024
@reshke
Copy link
Contributor Author

reshke commented Jul 26, 2024

I can actually do it myself, like cherry-pick series of patches.

However, these commit depends on out-of $subj scope work being merged in GPDB main. So, many conflict with applying as-is. Conflict are not very complicated themselves. But I wonder if there is some caveats that should be taken into account, maybe some guideline for back-porting features?

@my-ship-it
Copy link
Contributor

my-ship-it commented Jul 29, 2024

Hi @reshke, thanks for filing this issue.
Currently, the back-porting strategy is that we back-port GPDB specific commits(features and bug fixes) following the time line to get less conflicts with a commit history window of 1 - 2 months. But there is an exception for some important features, for example, resource group. We already back-ported features:
#432
#448

And currently, what is going on: #531

We welcome contributions from community, if you are interested, please don't hesitate to file PR following coding contribution guide

@reshke
Copy link
Contributor Author

reshke commented Aug 29, 2024

We welcome contributions from community, if you are interested, please don't hesitate to file PR following coding contribution guide

HI! How we can observe state of cherry-pick project, progress and work that yet to be done?

@tuhaihe
Copy link
Member

tuhaihe commented Aug 30, 2024

IMO, for the cherry-pick, it would be better to track using either a Kanban view or a table view within the GitHub project.

@tuhaihe
Copy link
Member

tuhaihe commented Sep 2, 2024

Follow-ups: @reshke, I will work with @my-ship-it to draft one proposal to track the cherry picks in public. When done, will let you know, and welcome to have your feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants