Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add support for Linux #18

Open
alois-gaucher opened this issue Mar 1, 2022 · 2 comments · May be fixed by #25
Open

Please add support for Linux #18

alois-gaucher opened this issue Mar 1, 2022 · 2 comments · May be fixed by #25
Labels
help wanted Extra attention is needed

Comments

@alois-gaucher
Copy link

Could you please add support for Linux ?

@antonreshetov antonreshetov added the help wanted Extra attention is needed label Mar 1, 2022
@lostdesign
Copy link

@antonreshetov you tagged this with help wanted - any particular reason? Is it due to the core dependencies?

You could implement https://github.com/marketplace/actions/electron-builder-action, I could probably help with that if I find the time for it. :D

@Christopher-Hayes
Copy link
Contributor

It already builds for Linux. To get the snap to install after building since it's not published to the snap store yet, you just need to use the --force-dangerous flag.

For example:

yarn run build
cd dist
sudo snap install ./image-optimizer_1.3.2_amd64.snap --force-dangerous

And yeah, the release build action would just need to be updated to build Linux as well. I guess it just builds Mac for now, but the config and support is all there.

Once the action is updated to build snap releases, the README would just need to say to use the `--force-dangerous`` install script until it's in the Snap store.

@Christopher-Hayes Christopher-Hayes linked a pull request Jun 5, 2022 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants