Incompatible types between PragmaRX\Countries\Package\Services\Cache\Service and Psr\SimpleCache\CacheInterface

[ghunti]

Hi @antonioribeiro

The latest version of thhis package, changed the compatiblity of the psr/simple-cache to ^3.0.
The problem is that now there's an incompatibility between PragmaRX\Countries\Package\Services\Cache\Service and Psr\SimpleCache\CacheInterface:

Declaration of PragmaRX\Countries\Package\Services\Cache\Service::get($key,  $default = null) 
must be compatible with Psr\SimpleCache\CacheInterface::get(string $key, mixed $default = null): mixed 

[antonioribeiro]

Yes, sorry about that, I believe I'll have to tag a major version on this one as it's a breaking change. Are you able to use a fixed version (previous one) for now?

[ghunti]

Hi @antonioribeiro
No problem on my side :-)
Would adding a return type of :mixed be considered a BC? Because I think it's the only thing missing

[ghunti]

Hello @antonioribeiro ? :-)

[ghunti]

Hey @antonioribeiro I think #203 fixes the issue

[antonioribeiro]

Hello @ghunti , unfortunately is never that simple. I just took some time to merge that PR and also move back to use Illuminate/Collections. Tests are mostly passing on both packages (Countries and Coollection), but we need help to fix the missing ones.

[ghunti]

Hey @antonioribeiro totally understand X-) Can you point me to the PR/branch where you are working? I might be able to help :-)