Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gdscript] missing base class lexer Reset() method #3613

Closed
kaby76 opened this issue Jul 14, 2023 · 0 comments · Fixed by #3614
Closed

[gdscript] missing base class lexer Reset() method #3613

kaby76 opened this issue Jul 14, 2023 · 0 comments · Fixed by #3614

Comments

@kaby76
Copy link
Contributor

kaby76 commented Jul 14, 2023 •
edited
Loading

For my upcoming change in #3598 I pointed out that there may be several grammars that are missing the Reset() method. The gdscript grammar is one of these.

Why is this important? The driver for the grammar first reads tokens from the lexer. It does so independently from the parser. Then, after calling Reset(), it performs a parse. If Reset() does not work, the parse will fail.
@kaby76 kaby76 mentioned this issue Jul 14, 2023
Merged
teverett pushed a commit that referenced this issue Jul 15, 2023
@kaby76
Fix #3613 (#3614)
bca917e
rvrooman-codelogic pushed a commit to CodeLogicIncEngineering/grammars-v4-public-fork that referenced this issue Jul 27, 2023
@kaby76 @rvrooman-codelogic
Fix antlr#3613 (antlr#3614)
31c8918
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[gdscript] Fix #3613 -- add reset() method
1 participant
@kaby76