Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ah_collections variable is used for 2 roles but have different requirements #388

Open
djdanielsson opened this issue Apr 26, 2024 · 1 comment
Labels
bug Something isn't working inactive

Comments

@djdanielsson
Copy link
Contributor

ah_collections variable is used for 2 roles but have different requirements. it is used in collection and publish role, I am thinking we probably need to either separate out the vars into two different ones to make sure you are calling the expected role (when using dispatch) or we need to align these two roles to have the same values names with maybe specific extra values for each. either way likely a breaking change.

@djdanielsson djdanielsson added bug Something isn't working new and removed new labels Apr 26, 2024
@sean-m-sullivan
Copy link
Contributor

While they were made for doing similar things, I had thought it was two use cases. Ones just the role wrapper, vs one is a builder/publish. So agree, just have to figure out what.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working inactive
Projects
None yet
Development

No branches or pull requests

2 participants