Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update python packaging: stop using "setup.py" #290

Open
TomasTomecek opened this issue Feb 6, 2023 · 4 comments
Open

update python packaging: stop using "setup.py" #290

TomasTomecek opened this issue Feb 6, 2023 · 4 comments

Comments

@TomasTomecek
Copy link
Collaborator

/usr/lib/python3.11/site-packages/setuptools/config/setupcfg.py:463: SetuptoolsDeprecationWarning: The license_file parameter is deprecated, use license_files instead.                                                                                      
  warnings.warn(msg, warning_class) 
/usr/lib/python3.11/site-packages/setuptools/command/install.py:34: SetuptoolsDeprecationWarning: setup.py install is deprecated. Use build and pip and other standards-based tools.                                                                         
  warnings.warn(

Adress these at minimum.

Since this affects what downstream distros have available, make sure to get a green light from downstream maintainers.

@grawlinson
Copy link
Contributor

setuptools is PEP-517 compliant, so there's no issue with continuing to use setuptools.

If you like, I can file a PR that combines setup.cfg and setup.py into the recommended PEP-517 pyproject.toml.

(I'm one of the downstream maintainers of ansible-bender for Arch Linux)

@TomasTomecek
Copy link
Collaborator Author

that would be perfect and so kind of you, I'd highly appreciate that

@webknjaz
Copy link
Member

webknjaz commented Feb 9, 2023

the recommended PEP-517 pyproject.toml.

It's a bit confusing but what you're referring to is PEP 518 rather than PEP 517 which only describes the build requirements.

Note that it's entirely possible to keep setup.py and use PEP 517. The deprecated bit is only invoking it in shell directly.

pyproject.toml metadata support is still kinda in beta so you may want to be careful with it.

@webknjaz
Copy link
Member

webknjaz commented Feb 9, 2024

pyproject.toml metadata support is still kinda in beta so you may want to be careful with it.

UPD: it's no longer in beta FYI. Though I personally still prefer a dedicated setup.cfg.

FWIW here's a few new and refreshed documents we posted on PyPUG:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants