Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate Vamp-IR into Taiga #157

Merged
merged 5 commits into from
May 17, 2023
Merged

Integrate Vamp-IR into Taiga #157

merged 5 commits into from
May 17, 2023

Conversation

XuyangSong
Copy link
Collaborator

@XuyangSong XuyangSong commented Apr 23, 2023 •
edited
Loading

  • Create predicate from vamp_ir circuit
  • Add some tests

@XuyangSong XuyangSong linked an issue Apr 23, 2023 that may be closed by this pull request
Integrate Vamp-IR into Taiga #151
Open
3 tasks
@XuyangSong
Copy link
Collaborator Author

XuyangSong commented Apr 23, 2023 •
edited
Loading

Some problems needed to discuss with Vampir Team:

  • Vampir lib doesn't compile.
  • How to handle instances(public inputs)? Vampir hardcoded the instances as empty, which needs to fix.
  • fn prompt_inputs is a private function in Vampir. We want to create proofs in Taiga. Could they make it public?
  • Could Vampir separate the parameter and circuit serialization? In Taiga, we have the Halo2 parameter in memory and only want the Vampir circuit. Reading the parameter every time is not efficient, since the parameter is huge.
  • update the dependencies(halo2_proofs, halo2_gadgets, group, ff) in Vampir

@XuyangSong XuyangSong mentioned this pull request Apr 23, 2023
Open
3 tasks
This was referenced Apr 25, 2023
Open
Closed
@lopeetall
Copy link

@XuyangSong can you explain the problem with parameter range in Vamp-IR? The code I'm looking at appears to size the parameters according to the size of the circuit, and we've definitely used circuits with > 2^12 constraints, so I'm surprised at this one

@XuyangSong
Copy link
Collaborator Author

@XuyangSong can you explain the problem with parameter range in Vamp-IR? The code I'm looking at appears to size the parameters according to the size of the circuit, and we've definitely used circuits with > 2^12 constraints, so I'm surprised at this one

Sorry, I misunderstood the parameter AllowedEnumVariants. Thanks for the explanation. I removed this one.

@XuyangSong XuyangSong changed the title WIP: Integrate Vamp-IR into Taiga Integrate Vamp-IR into Taiga May 10, 2023
@XuyangSong XuyangSong marked this pull request as ready for review May 10, 2023 15:59
@XuyangSong XuyangSong requested a review from bazzilic May 10, 2023 15:59
bazzilic
bazzilic approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@bazzilic bazzilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@XuyangSong XuyangSong merged commit 6609f8e into main May 17, 2023
@XuyangSong XuyangSong deleted the xuyang/integrate_vampir branch May 30, 2023 06:21
@paulcadman paulcadman mentioned this pull request Jun 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bazzilic bazzilic bazzilic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate Vamp-IR into Taiga
3 participants
@XuyangSong @lopeetall @bazzilic