Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu handled by DeckPicker instead of StudyOptionsFragment #17099

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Menu handled by DeckPicker instead of StudyOptionsFragment #17099

wants to merge 1 commit into from
+43 −53

Conversation

SanjaySargam
Copy link
Contributor

@SanjaySargam SanjaySargam commented Sep 21, 2024 •
edited by david-allison
Loading

Purpose / Description

DeckPicker should handle menu responsibility instead of StudyOptionsFramgment (Tablet)
I reverted some changes from PR #16425

Fixes

How Has This Been Tested?

Emulator

deckpicker_menu.mp4

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@SanjaySargam SanjaySargam marked this pull request as ready for review September 26, 2024 18:35
david-allison
david-allison requested changes Oct 9, 2024
View reviewed changes
Copy link
Member

@david-allison david-allison left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following should not be visible if the collection is empty [fragment is invisible]:

A unit test, or @NeedsTest should be added for these cases

@david-allison david-allison added the Needs Author Reply Waiting for a reply from the original author label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-allison david-allison david-allison requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Needs Author Reply Waiting for a reply from the original author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DeckPicker should handle menu responsibility instead of StudyOptionsFramgment (Tablet)
2 participants
@SanjaySargam @david-allison