Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated docusaurus #1172

Closed
wants to merge 1 commit into from
Closed

Updated docusaurus #1172

wants to merge 1 commit into from

Conversation

msaini28r
Copy link

@msaini28r msaini28r commented Oct 22, 2021

The link is updated. #1167

Description

Fixes #1167

Type of Change:

  • Code
  • Quality Assurance
  • User Interface
  • Outreach
  • Documentation

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update (software upgrade on readme file)
  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

Checklist:

  • My PR follows the style guidelines of this project
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged

Code/Quality Assurance Only

  • My changes generate no new warnings

The link is updated. #1167
@msaini28r
Copy link
Author

@isabelcosta changes done. #1167

Copy link
Member

@isabelcosta isabelcosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msaini0r can you please provide a screenshot of this icon showing up on docuraurus page, in the "How Has This Been Tested?" section of the PR description? I noticed in another project, that the medium icon did not show up. So I wonder if this is working as expected 🤔

Copy link
Member

@vj-codes vj-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msaini0r hey also update to this change and run docusaurus locally to test it.
I guess the command is npm start and add a screenshot of the footer :)

@@ -57,6 +57,7 @@ module.exports = {
<a href="https://twitter.com/anitab_org" rel="noopener noreferrer" target="_blank"><i id="social-tw" class="fa fa-twitter-square fa-3x social"></i></a>
<a href="https://www.linkedin.com/company/anitab-org/" rel="noopener noreferrer" target="_blank"><i id="fa fa-linkedin-square fa-3x social" class="fa fa-linkedin-square fa-3x social"></i></a>
<a href="https://www.instagram.com/anitab_org/" rel="noopener noreferrer" target="_blank"><i id="fa fa-instagram-square fa-2x social" class="fa fa-instagram fa-3x social"></i></a>
<a href="https://medium.com/anitab-org-open-source" rel="noopener noreferrer" target="_blank"><i id="fa fa-medium-square fa-2x social" class="fa fa-instagram fa-3x social"></i></a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<a href="https://medium.com/anitab-org-open-source" rel="noopener noreferrer" target="_blank"><i id="fa fa-medium-square fa-2x social" class="fa fa-instagram fa-3x social"></i></a>
<a href="https://medium.com/anitab-org-open-source" rel="noopener noreferrer" target="_blank"><i id="fa fa-medium-square fa-2x social" class="fa fa-medium fa-3x social"></i></a>

@vj-codes
Copy link
Member

@msaini0r hey any updates?

@vj-codes
Copy link
Member

Closing this PR due to inactivity.
Thank you for your contribution @msaini0r :)

@vj-codes vj-codes closed this Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add link with icon to our AnitaB.org Open Source Medium
3 participants