Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle between oob and legacy invitations #94

Closed
TimoGlastra opened this issue Sep 2, 2022 · 1 comment · Fixed by #109
Closed

Toggle between oob and legacy invitations #94

TimoGlastra opened this issue Sep 2, 2022 · 1 comment · Fixed by #109

Comments

@TimoGlastra
Copy link
Member

See #87 for general context

  1. Add useLegacyInvitations boolean type to the connectionSlice.ts. True should be the default
  2. add setUseLegacyInvitations to the reducers in the connections slice that sets wheter to use legacy invitations on the state.
  3. Add option "Change Connection Invitation Type" with options "Legacy (RFC 0160)" and "Out Of Band" to the KBar.tsx file.
  4. (ideally) add a way to see if we're using legacy / oob invitation from kbar (timc1/kbar)
  5. Whenever we create an invitation we should call /oob/create-legacy-invitation if legacy is enabled, and /oob/create-invitation otherwise. In both cases we should use the return invitaiton url and encode is as a QR (as is already happening)
@janrtvld
Copy link
Contributor

For number 4: maybe a checkmark to indicate the type that is active? Like this:

Group 2

@janrtvld janrtvld linked a pull request Oct 6, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants