Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image after setup same for all use cases #6

Open
janrtvld opened this issue Jan 5, 2022 · 0 comments
Open

Image after setup same for all use cases #6

janrtvld opened this issue Jan 5, 2022 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers UI

Comments

@janrtvld
Copy link
Contributor

janrtvld commented Jan 5, 2022

Currently the image at "You're all set!" is the same for all use cases. Because it features some characters with their back turned and one central character, it seems especially suited to customize it with the chosen player, instead of a generic pic.

Screenshot from 2022-01-04 11-34-15

We can do this by dynamically changing the images that we add to the final screen based on the character selected. Images can be found on here.

We can change the getComponentToRender in OnboardingContainer to add an image to the Progress.SETUP_COMPLETED based on the character chosen.

@janrtvld janrtvld added the enhancement New feature or request label Jan 5, 2022
@janrtvld janrtvld added the UI label Aug 30, 2022
@janrtvld janrtvld changed the title image after setup same for all use cases Image after setup same for all use cases Sep 2, 2022
@janrtvld janrtvld added the good first issue Good for newcomers label Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers UI
Projects
None yet
Development

No branches or pull requests

1 participant