Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing galactic_expanding_shell branch #77

Open
sona-patel opened this issue Dec 21, 2022 · 4 comments
Open

Testing galactic_expanding_shell branch #77

sona-patel opened this issue Dec 21, 2022 · 4 comments

Comments

@sona-patel
Copy link

Hi @andreatramacere,

Very glad to see the JetSet evolving so fast and now also having preliminary implementation for Galactic objects! 👏🏻

Isn't that the very first line on the documentation page should read as 1) GalacticBeamed to hadle galatcit objects that are not beamed 2) GalacticUnbeamed to hadle galatcit objects that are not beamed ?

Thanks!

@andreatramacere
Copy link
Owner

Hi @sona-patel, yes you are right, in any case, I did some more improvements not yet released, such as adding an expanding shell geometry. If you are interested you can try the branch 'galactic_expanding_shell', but it is still experimental, even though a postdoc in Japan used it to reproduce the RS Ophiuchi results published in the MAGIC paper. I guess I will have something ready to experiment early next year, but if you are interested I can provide you with some notebooks after the Xmas break.

@sona-patel
Copy link
Author

That's nice! I will also give more serious try early next year! - Thanks!

@sona-patel
Copy link
Author

Hi @andreatramacere , I tested the 'galactic_expanding_shell' branch of Jetset! I can run smoothly galactic object models. However, I get the following errors while running the test:

Failures in '$ pytest --pyargs -vvv jetset.tests.test_users::TestUser':

==================================== test session starts ====================================
platform darwin -- Python 3.9.16, pytest-7.2.1, pluggy-1.0.0 -- /Users/sonal/anaconda3/envs/jetset_expanding_shell/bin/python3.9
cachedir: .pytest_cache
rootdir: /Users/sonal/test_jetset
plugins: anyio-3.5.0
collected 5 items

::TestUser::test_jet <- ../anaconda3/envs/jetset_expanding_shell/lib/python3.9/site-packages/jetset/tests/test_users.py

model description:

type: Jet
FAILED [ 20%]
::TestUser::test_emitters <- ../anaconda3/envs/jetset_expanding_shell/lib/python3.9/site-packages/jetset/tests/test_users.py PASSED [ 40%]
::TestUser::test_dep_pars <- ../anaconda3/envs/jetset_expanding_shell/lib/python3.9/site-packages/jetset/tests/test_users.py FAILED [ 60%]
::TestUser::test_composit_model <- ../anaconda3/envs/jetset_expanding_shell/lib/python3.9/site-packages/jetset/tests/test_users.py PASSED [ 80%]
::TestUser::test_composit_ebl <- ../anaconda3/envs/jetset_expanding_shell/lib/python3.9/site-packages/jetset/tests/test_users.py PASSED [100%]

========================================= FAILURES ==========================================
_____________________________________ TestUser.test_jet _____________________________________

self = <jetset.tests.test_users.TestUser object at 0x7fda0e02fd60>
plot = <function plot at 0x7fda0d336ee0>

def test_jet(self,plot=plot):
   t=TestJets()
   t.test_jet(plot=plot)
   t.test_set_N_from_nuFnu(plot=plot)
   t.test_EC(plot=plot)
 t.test_hadronic_jet(plot=plot)

../anaconda3/envs/jetset_expanding_shell/lib/python3.9/site-packages/jetset/tests/test_users.py:29:


../anaconda3/envs/jetset_expanding_shell/lib/python3.9/site-packages/jetset/tests/test_jet_model.py:18: in test_hadronic_jet
j = Jet(proton_distribution='plc')


self = <[AttributeError("'Jet' object has no attribute 'name'") raised in repr()] Jet object at 0x7fda136abaf0>
cosmo = None, name = None, emitters_type = 'electrons', emitters_distribution = 'plc'
emitters_distribution_log_values = False, beaming_expr = 'delta', T_esc_e_second = None
jet_workplace = None, verbose = None, clean_work_dir = True, electron_distribution = None
proton_distribution = 'plc', electron_distribution_log_values = None
proton_distribution_log_values = None, geometry = 'spherical'

def __init__(self,
             cosmo=None,
             name=None,
             emitters_type='electrons',
             emitters_distribution='plc',
             emitters_distribution_log_values=False,
             beaming_expr='delta',
             T_esc_e_second=None,
             jet_workplace=None,
             verbose=None,
             clean_work_dir=True,
             electron_distribution=None,
             proton_distribution=None,
             electron_distribution_log_values=None,
             proton_distribution_log_values=None,
             geometry='spherical'):
    """

    Parameters
    ----------
    cosmo
    name
    emitters_type
    emitters_distribution
    emitters_distribution_log_values
    beaming_expr
    T_esc_e_second
    jet_workplace
    verbose
    clean_work_dir
    electron_distribution
    proton_distribution
    electron_distribution_log_values
    proton_distribution_log_values
    """
    if electron_distribution is not None and emitters_type == 'protons':
        raise RuntimeError("if you provide an electron_distribution, you can't set emitters_type=",emitters_type, 'use emitters_distribution instead')

    if proton_distribution is not None and emitters_type == 'electrons':
      raise RuntimeError("if you provide a proton_distribution, you can't set emitters_type=",emitters_type, 'use emitters_distribution instead')

E RuntimeError: ("if you provide a proton_distribution, you can't set emitters_type=", 'electrons', 'use emitters_distribution instead')

../anaconda3/envs/jetset_expanding_shell/lib/python3.9/site-packages/jetset/jet_model.py:1625: RuntimeError
----------------------------------- Captured stdout call ------------------------------------
--------> test_jet <function plot at 0x7fda0d336ee0>
name type units val


BulkLorentzFactor jet-bulk-factor 1.000000e+01
U_e Energy dens. blob rest. frame erg / cm3 1.299489e-03
U_p_cold Energy dens. blob rest. frame erg / cm3 1.503276e-02
U_B Energy dens. blob rest. frame erg / cm3 3.978874e-04
U_Synch Energy dens. blob rest. frame erg / cm3 1.187517e-06
U_Synch_DRF Energy dens. disk rest. frame erg / cm3 1.187517e-02
U_Disk Energy dens. blob rest. frame erg / cm3 0.000000e+00
U_BLR Energy dens. blob rest. frame erg / cm3 0.000000e+00
U_DT Energy dens. blob rest. frame erg / cm3 0.000000e+00
U_CMB Energy dens. blob rest. frame erg / cm3 0.000000e+00
U_Star Energy dens. blob rest. frame erg / cm3 0.000000e+00
U_Disk_DRF Energy dens. disk rest. frame erg / cm3 0.000000e+00
U_BLR_DRF Energy dens. disk rest. frame erg / cm3 0.000000e+00
U_DT_DRF Energy dens. disk rest. frame erg / cm3 0.000000e+00
U_CMB_DRF Energy dens. disk rest. frame erg / cm3 0.000000e+00
U_Star_DRF Energy dens. disk rest. frame erg / cm3 0.000000e+00
U_seed_tot Energy dens. blob rest. frame erg / cm3 1.187517e-06
L_Sync_rf Lum. blob rest. frame. erg / s 1.118434e+37
L_SSC_rf Lum. blob rest. frame. erg / s 7.050994e+34
L_EC_Disk_rf Lum. blob rest. frame. erg / s 0.000000e+00
L_EC_BLR_rf Lum. blob rest. frame. erg / s 0.000000e+00
L_EC_DT_rf Lum. blob rest. frame. erg / s 0.000000e+00
L_EC_CMB_rf Lum. blob rest. frame. erg / s 0.000000e+00
L_EC_Star_rf Lum. blob rest. frame. erg / s 6.953119e-310
jet_L_Sync jet Lum. erg / s 2.782070e+38
jet_L_SSC jet Lum. erg / s 1.753913e+36
jet_L_EC_Disk jet Lum. erg / s 0.000000e+00
jet_L_EC_BLR jet Lum. erg / s 0.000000e+00
jet_L_EC_Star jet Lum. erg / s 6.945305e-310
jet_L_EC_DT jet Lum. erg / s 0.000000e+00
jet_L_EC_CMB jet Lum. erg / s 0.000000e+00
jet_L_pp_gamma jet Lum. erg / s 0.000000e+00
jet_L_rad jet Lum. erg / s 2.799609e+38
jet_L_kin jet Lum. erg / s 3.826258e+42
jet_L_tot jet Lum. erg / s 3.919754e+42
jet_L_e jet Lum. erg / s 3.044393e+41
jet_L_B jet Lum. erg / s 9.321554e+40
jet_L_p_cold jet Lum. erg / s 3.521819e+42
NH_cold_to_rel_e cold_p_to_rel_e_ratio 1.000000e-01
model name name par type units val phys. bound. min phys. bound. max log frozen


jet_leptonic gmin low-energy-cut-off lorentz-factor* 2.000000e+00 1.000000e+00 1.000000e+09 False False
jet_leptonic gmax high-energy-cut-off lorentz-factor* 1.000000e+06 1.000000e+00 1.000000e+15 False False
jet_leptonic N emitters_density 1 / cm3 1.000000e+02 0.000000e+00 -- False False
jet_leptonic gamma_cut turn-over-energy lorentz-factor* 1.000000e+04 1.000000e+00 1.000000e+09 False False
jet_leptonic p LE_spectral_slope 2.000000e+00 -1.000000e+01 1.000000e+01 False False
jet_leptonic R region_size cm 5.000000e+15 1.000000e+03 1.000000e+30 False False
jet_leptonic R_H region_position cm 1.000000e+17 0.000000e+00 -- False True
jet_leptonic B magnetic_field gauss 1.000000e-01 0.000000e+00 -- False False
jet_leptonic NH_cold_to_rel_e cold_p_to_rel_e_ratio 1.000000e-01 0.000000e+00 -- False True
jet_leptonic beam_obj beaming lorentz-factor* 1.000000e+01 1.000000e-04 -- False False
jet_leptonic z_cosm redshift 1.000000e-01 0.000000e+00 -- False False
name type units val


BulkLorentzFactor jet-bulk-factor 1.000000e+01
U_e Energy dens. blob rest. frame erg / cm3 1.299489e-03
U_p_cold Energy dens. blob rest. frame erg / cm3 1.503276e-02
U_B Energy dens. blob rest. frame erg / cm3 3.978874e-04
U_Synch Energy dens. blob rest. frame erg / cm3 1.187517e-06
U_Synch_DRF Energy dens. disk rest. frame erg / cm3 1.187517e-02
U_Disk Energy dens. blob rest. frame erg / cm3 0.000000e+00
U_BLR Energy dens. blob rest. frame erg / cm3 0.000000e+00
U_DT Energy dens. blob rest. frame erg / cm3 0.000000e+00
U_CMB Energy dens. blob rest. frame erg / cm3 0.000000e+00
U_Star Energy dens. blob rest. frame erg / cm3 0.000000e+00
U_Disk_DRF Energy dens. disk rest. frame erg / cm3 0.000000e+00
U_BLR_DRF Energy dens. disk rest. frame erg / cm3 0.000000e+00
U_DT_DRF Energy dens. disk rest. frame erg / cm3 0.000000e+00
U_CMB_DRF Energy dens. disk rest. frame erg / cm3 0.000000e+00
U_Star_DRF Energy dens. disk rest. frame erg / cm3 0.000000e+00
U_seed_tot Energy dens. blob rest. frame erg / cm3 1.187517e-06
L_Sync_rf Lum. blob rest. frame. erg / s 1.118434e+37
L_SSC_rf Lum. blob rest. frame. erg / s 7.050994e+34
L_EC_Disk_rf Lum. blob rest. frame. erg / s 0.000000e+00
L_EC_BLR_rf Lum. blob rest. frame. erg / s 0.000000e+00
L_EC_DT_rf Lum. blob rest. frame. erg / s 0.000000e+00
L_EC_CMB_rf Lum. blob rest. frame. erg / s 0.000000e+00
L_EC_Star_rf Lum. blob rest. frame. erg / s 6.953119e-310
jet_L_Sync jet Lum. erg / s 2.782070e+38
jet_L_SSC jet Lum. erg / s 1.753913e+36
jet_L_EC_Disk jet Lum. erg / s 0.000000e+00
jet_L_EC_BLR jet Lum. erg / s 0.000000e+00
jet_L_EC_Star jet Lum. erg / s 6.945305e-310
jet_L_EC_DT jet Lum. erg / s 0.000000e+00
jet_L_EC_CMB jet Lum. erg / s 0.000000e+00
jet_L_pp_gamma jet Lum. erg / s 0.000000e+00
jet_L_rad jet Lum. erg / s 2.799609e+38
jet_L_kin jet Lum. erg / s 3.826258e+42
jet_L_tot jet Lum. erg / s 3.919754e+42
jet_L_e jet Lum. erg / s 3.044393e+41
jet_L_B jet Lum. erg / s 9.321554e+40
jet_L_p_cold jet Lum. erg / s 3.521819e+42
NH_cold_to_rel_e cold_p_to_rel_e_ratio 1.000000e-01
--------> test_set_N_from_nuFnu <function plot at 0x7fda0d336ee0>
--------> test_EC <function plot at 0x7fda0d336ee0>
--------> test_hadronic_jet <function plot at 0x7fda0d336ee0>
__________________________________ TestUser.test_dep_pars ___________________________________

args = (<jetset.jet_paramters.JetParameter object at 0x7fda0f2966a0>,), kwargs = {'val': 2.0}
message = 'the jetkernel failed\n\n exception message: \ns1+1 argument after ** must be a mapping, not list'

def func_wrapper(*args, **kwargs):
    try:
      return func(*args, **kwargs)

../anaconda3/envs/jetset_expanding_shell/lib/python3.9/site-packages/jetset/utils.py:93:


self = <jetset.jet_paramters.JetParameter object at 0x7fda0f2966a0>, keywords = {'val': 2.0}

@safe_run
def set(self,**keywords):
    """
    overrides the  :meth:`.ModelParameter.set` method in order to propagate the
    parameter value to the BlazarSED object instance
    """
  super(JetParameter,self).set(**keywords )

../anaconda3/envs/jetset_expanding_shell/lib/python3.9/site-packages/jetset/jet_paramters.py:110:


self = <jetset.jet_paramters.JetParameter object at 0x7fda0f2966a0>
skip_dep_par_warning = False, args = (), keywords = {'val': 2.0}, keys = dict_keys(['val'])
kw = 'val', p = <jetset.jet_paramters.JetParameter object at 0x7fda0f296580>

def set(self, *args, skip_dep_par_warning=False, **keywords):
    """
    sets a parameter value checking for physical boundaries

    Parameters: keywords of the constructor

    """
    keys = keywords.keys()
    if self.immutable is False or skip_dep_par_warning is True:
        pass
    else:
        #warnings.warn('\n\n *** you are trying to set a dependent parameter:%s *** \n'%self.name)
        raise RuntimeError('\n\n *** you are trying to set a dependent parameter:%s *** \n'%self.name)
        #return


    for kw in keys:

        if kw in  self.allowed_keywords.keys() :
            if kw == 'val':

                if self.allowed_values is not None:

                    if keywords[kw] not in self.allowed_values:
                        raise RuntimeError('parameter  %s' %(self.name), 'the value', keywords[kw] , 'is not in the allowed list',self.allowed_values)

                self._val.val = keywords[kw]
                if self._depending_pars is not []:
                    for p in self._depending_pars:
                        #print("==> setting dep par",p.name, 'to',p._func(),'p=',p,'master',self,'name',self.name)
                      p.set(val=p._func(),skip_dep_par_warning=True)

../anaconda3/envs/jetset_expanding_shell/lib/python3.9/site-packages/jetset/model_parameters.py:429:


self = <jetset.jet_paramters.JetParameter object at 0x7fda0f296580>

def _eval_par_func(self):
    #transform par name and value into a local var
    #print('working on ',self.name)
    #TODO:THIS HOLDS ONLY FOR NUMPY <1.22, should be removed
    warnings.filterwarnings('ignore', message='invalid value encountered in reciprocal*')
    if type(self._depending_par_expr) == str:
        _par_values= [None]*len(self._master_pars)
        for ID, _user_par_ in enumerate(self._master_pars):
            _par_values[ID] = _user_par_.val_lin*_user_par_.units
            #print('==> _eval_par_func',_user_par_.name,_par_values[ID])
            exec(_user_par_.name + '=_par_values[ID]')
        res = eval(self._depending_par_expr)
    elif callable(self._depending_par_expr) is True:
        _par_values={}
        for ID, _user_par_ in enumerate(self._master_pars):
            _par_values[_user_par_.name] = _user_par_.val_lin*_user_par_.units
            #print(_user_par_.name,_user_par_.val_lin)
        res=self._depending_par_expr(**_par_values)
    #TODO:THIS HOLDS ONLY FOR NUMPY <1.22, should be removed
  res=self._depending_par_expr(**_par_values)

E TypeError: s1+1 argument after ** must be a mapping, not list

../anaconda3/envs/jetset_expanding_shell/lib/python3.9/site-packages/jetset/model_parameters.py:378: TypeError

During handling of the above exception, another exception occurred:

self = <jetset.tests.test_users.TestUser object at 0x7fda0e02fb20>
plot = <function plot at 0x7fda0d336ee0>

def test_dep_pars(self,plot=plot):
   t=TestDependingParameters()
 t.integration_suite()

../anaconda3/envs/jetset_expanding_shell/lib/python3.9/site-packages/jetset/tests/test_users.py:37:


../anaconda3/envs/jetset_expanding_shell/lib/python3.9/site-packages/jetset/tests/test_depending_parameters.py:7: in integration_suite
self._all(plot=plot)
../anaconda3/envs/jetset_expanding_shell/lib/python3.9/site-packages/jetset/tests/base_class.py:9: in _all
m1
../anaconda3/envs/jetset_expanding_shell/lib/python3.9/site-packages/jetset/tests/test_depending_parameters.py:33: in test_dep_par
j.make_dependent_par(par='s2', depends_on=['s1'], par_expr='s1+1')
../anaconda3/envs/jetset_expanding_shell/lib/python3.9/site-packages/jetset/base_model.py:385: in make_dependent_par
m.val=m.val
../anaconda3/envs/jetset_expanding_shell/lib/python3.9/site-packages/jetset/model_parameters.py:257: in val
self.set(val=val)


args = (<jetset.jet_paramters.JetParameter object at 0x7fda0f2966a0>,), kwargs = {'val': 2.0}
message = 'the jetkernel failed\n\n exception message: \ns1+1 argument after ** must be a mapping, not list'

def func_wrapper(*args, **kwargs):
    try:
        return func(*args, **kwargs)
    except Exception as e:
       message =  'the jetkernel failed\n'
       message += '\n exception message: \n'
       message += '%s'%str(e)
       new_version_warning()
     raise JetkerneltException(message=message)

E jetset.utils.JetkerneltException: the jetkernel failed
E
E exception message:
E s1+1 argument after ** must be a mapping, not list

../anaconda3/envs/jetset_expanding_shell/lib/python3.9/site-packages/jetset/utils.py:100: JetkerneltException
----------------------------------- Captured stdout call ------------------------------------
name par type units val phys. bound. min phys. bound. max log frozen


   gmin  low-energy-cut-off lorentz-factor* 2.000000e+00     1.000000e+00     1.000000e+09 False  False
   gmax high-energy-cut-off lorentz-factor* 1.000000e+06     1.000000e+00     1.000000e+15 False  False
      N    emitters_density         1 / cm3 1.000000e+02     0.000000e+00               -- False  False

gamma_break turn-over-energy lorentz-factor* 1.000000e+03 1.000000e+00 -- False False
s1 LE_spectral_slope 2.500000e+00 -1.000000e+01 1.000000e+01 False False
s2 LE_spectral_slope 3.200000e+00 -1.000000e+01 1.000000e+01 False False
name par type units val phys. bound. min phys. bound. max log frozen


   gmin  low-energy-cut-off lorentz-factor* 2.000000e+00     1.000000e+00     1.000000e+09 False  False
   gmax high-energy-cut-off lorentz-factor* 1.000000e+06     1.000000e+00     1.000000e+15 False  False
      N    emitters_density         1 / cm3 1.000000e+02     0.000000e+00               -- False  False

gamma_break turn-over-energy lorentz-factor* 1.000000e+03 1.000000e+00 -- False False
s1 LE_spectral_slope 2.000000e+00 -1.000000e+01 1.000000e+01 False False
s2 LE_spectral_slope 3.500000e+00 -1.000000e+01 1.000000e+01 False False
===================================== warnings summary ======================================
: 104 warnings
/Users/sonal/anaconda3/envs/jetset_expanding_shell/lib/python3.9/site-packages/jetset/model_parameters.py:1121: DeprecationWarning: np.float is a deprecated alias for the builtin float. To silence this warning, use float by itself. Doing this will not modify any behavior and is safe. If you specifically wanted the numpy scalar type, use np.float64 here.
Deprecated in NumPy 1.20; for more details and guidance: https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations
t[n] = MaskedColumn(t[n].data, name=n, dtype=np.float)

: 67 warnings
/Users/sonal/anaconda3/envs/jetset_expanding_shell/lib/python3.9/site-packages/jetset/model_parameters.py:1119: DeprecationWarning: np.float is a deprecated alias for the builtin float. To silence this warning, use float by itself. Doing this will not modify any behavior and is safe. If you specifically wanted the numpy scalar type, use np.float64 here.
Deprecated in NumPy 1.20; for more details and guidance: https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations
t[n] = MaskedColumn(t[n].data, name=n, dtype=np.float, mask=t[n].data==None)

::TestUser::test_jet
::TestUser::test_jet
::TestUser::test_emitters
::TestUser::test_emitters
/Users/sonal/anaconda3/envs/jetset_expanding_shell/lib/python3.9/site-packages/jetset/jet_emitters.py:213: DeprecationWarning: np.bool is a deprecated alias for the builtin bool. To silence this warning, use bool by itself. Doing this will not modify any behavior and is safe. If you specifically wanted the numpy scalar type, use np.bool_ here.
Deprecated in NumPy 1.20; for more details and guidance: https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations
msk = np.ones(x.shape, dtype=np.bool)

::TestUser::test_dep_pars
/Users/sonal/anaconda3/envs/jetset_expanding_shell/lib/python3.9/site-packages/jetset/utils.py:54: UserWarning:


Something wrong has happened. Please, look at the exception message.


warnings.warn(m)

::TestUser::test_composit_model
::TestUser::test_composit_ebl
::TestUser::test_composit_ebl
/Users/sonal/anaconda3/envs/jetset_expanding_shell/lib/python3.9/site-packages/jetset/template_2Dmodel.py:295: DeprecationWarning: np.float is a deprecated alias for the builtin float. To silence this warning, use float by itself. Doing this will not modify any behavior and is safe. If you specifically wanted the numpy scalar type, use np.float64 here.
Deprecated in NumPy 1.20; for more details and guidance: https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations
x_values = np.array(data.meta['redshift'], dtype=np.float)

::TestUser::test_composit_model
::TestUser::test_composit_ebl
/Users/sonal/anaconda3/envs/jetset_expanding_shell/lib/python3.9/site-packages/jetset/model_manager.py:147: UserWarning: no cosmology defined, using default FlatLambdaCDM(name="Planck13", H0=67.8 km / (Mpc s), Om0=0.307, Tcmb0=2.725 K, Neff=3.05, m_nu=[0. 0. 0.06] eV, Ob0=0.0483)
warnings.warn('no cosmology defined, using default %s'%self.cosmo)

::TestUser::test_composit_ebl
::TestUser::test_composit_ebl
/Users/sonal/anaconda3/envs/jetset_expanding_shell/lib/python3.9/site-packages/jetset/template_2Dmodel.py:293: DeprecationWarning: np.float is a deprecated alias for the builtin float. To silence this warning, use float by itself. Doing this will not modify any behavior and is safe. If you specifically wanted the numpy scalar type, use np.float64 here.
Deprecated in NumPy 1.20; for more details and guidance: https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations
x_values = np.array(data.meta['REDSHIFT'], dtype=np.float)

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
================================== short test summary info ==================================
FAILED ::TestUser::test_jet - RuntimeError: ("if you provide a proton_distribution, you can't set emitters_type=", 'el...
FAILED ::TestUser::test_dep_pars - jetset.utils.JetkerneltException: the jetkernel failed
======================== 2 failed, 3 passed, 183 warnings in 35.01s =========================

Thanks!

@sona-patel sona-patel changed the title Possible typo in Galactic models's documentation (Minor) Testing galactic_expanding_shell branch Feb 22, 2023
@andreatramacere
Copy link
Owner

@sona-patel, Hi, I did not finalise all the tests. I have pushed a change, now the test should work. You can test also multithreading, and it will be faster, for example, if you have a jet model you can:

jet._blob.N_THREADS=8

This will build 8 threads in the C code. On my laptop, with N_THREADS=8, I get ~ 3 times faster. This is still experimental, the thumb rule is to use N_THREADS~2*(number of your CPU cores)

These days I am super busy, but I should have a release during the next two months

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants