-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing galactic_expanding_shell
branch
#77
Comments
Hi @sona-patel, yes you are right, in any case, I did some more improvements not yet released, such as adding an expanding shell geometry. If you are interested you can try the branch 'galactic_expanding_shell', but it is still experimental, even though a postdoc in Japan used it to reproduce the RS Ophiuchi results published in the MAGIC paper. I guess I will have something ready to experiment early next year, but if you are interested I can provide you with some notebooks after the Xmas break. |
That's nice! I will also give more serious try early next year! - Thanks! |
Hi @andreatramacere , I tested the 'galactic_expanding_shell' branch of Jetset! I can run smoothly galactic object models. However, I get the following errors while running the test: Failures in '$ pytest --pyargs -vvv jetset.tests.test_users::TestUser':
==================================== test session starts ==================================== ::TestUser::test_jet <- ../anaconda3/envs/jetset_expanding_shell/lib/python3.9/site-packages/jetset/tests/test_users.pymodel description:type: Jet ========================================= FAILURES ========================================== self = <jetset.tests.test_users.TestUser object at 0x7fda0e02fd60>
../anaconda3/envs/jetset_expanding_shell/lib/python3.9/site-packages/jetset/tests/test_users.py:29: ../anaconda3/envs/jetset_expanding_shell/lib/python3.9/site-packages/jetset/tests/test_jet_model.py:18: in test_hadronic_jet self = <[AttributeError("'Jet' object has no attribute 'name'") raised in repr()] Jet object at 0x7fda136abaf0>
E RuntimeError: ("if you provide a proton_distribution, you can't set emitters_type=", 'electrons', 'use emitters_distribution instead') ../anaconda3/envs/jetset_expanding_shell/lib/python3.9/site-packages/jetset/jet_model.py:1625: RuntimeError BulkLorentzFactor jet-bulk-factor 1.000000e+01 jet_leptonic gmin low-energy-cut-off lorentz-factor* 2.000000e+00 1.000000e+00 1.000000e+09 False False BulkLorentzFactor jet-bulk-factor 1.000000e+01 args = (<jetset.jet_paramters.JetParameter object at 0x7fda0f2966a0>,), kwargs = {'val': 2.0}
../anaconda3/envs/jetset_expanding_shell/lib/python3.9/site-packages/jetset/utils.py:93: self = <jetset.jet_paramters.JetParameter object at 0x7fda0f2966a0>, keywords = {'val': 2.0}
../anaconda3/envs/jetset_expanding_shell/lib/python3.9/site-packages/jetset/jet_paramters.py:110: self = <jetset.jet_paramters.JetParameter object at 0x7fda0f2966a0>
../anaconda3/envs/jetset_expanding_shell/lib/python3.9/site-packages/jetset/model_parameters.py:429: self = <jetset.jet_paramters.JetParameter object at 0x7fda0f296580>
E TypeError: s1+1 argument after ** must be a mapping, not list ../anaconda3/envs/jetset_expanding_shell/lib/python3.9/site-packages/jetset/model_parameters.py:378: TypeError During handling of the above exception, another exception occurred: self = <jetset.tests.test_users.TestUser object at 0x7fda0e02fb20>
../anaconda3/envs/jetset_expanding_shell/lib/python3.9/site-packages/jetset/tests/test_users.py:37: ../anaconda3/envs/jetset_expanding_shell/lib/python3.9/site-packages/jetset/tests/test_depending_parameters.py:7: in integration_suite args = (<jetset.jet_paramters.JetParameter object at 0x7fda0f2966a0>,), kwargs = {'val': 2.0}
E jetset.utils.JetkerneltException: the jetkernel failed ../anaconda3/envs/jetset_expanding_shell/lib/python3.9/site-packages/jetset/utils.py:100: JetkerneltException
gamma_break turn-over-energy lorentz-factor* 1.000000e+03 1.000000e+00 -- False False
gamma_break turn-over-energy lorentz-factor* 1.000000e+03 1.000000e+00 -- False False : 67 warnings ::TestUser::test_jet ::TestUser::test_dep_pars Something wrong has happened. Please, look at the exception message.
::TestUser::test_composit_model ::TestUser::test_composit_model ::TestUser::test_composit_ebl -- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html Thanks! |
galactic_expanding_shell
branch
@sona-patel, Hi, I did not finalise all the tests. I have pushed a change, now the test should work. You can test also multithreading, and it will be faster, for example, if you have a jet model you can:
This will build 8 threads in the C code. On my laptop, with N_THREADS=8, I get ~ 3 times faster. This is still experimental, the thumb rule is to use N_THREADS~2*(number of your CPU cores) These days I am super busy, but I should have a release during the next two months |
Hi @andreatramacere,
Very glad to see the JetSet evolving so fast and now also having preliminary implementation for Galactic objects! 👏🏻
Isn't that the very first line on the documentation page should read as 1) GalacticBeamed to hadle galatcit objects that are
notbeamed 2) GalacticUnbeamed to hadle galatcit objects that are not beamed ?Thanks!
The text was updated successfully, but these errors were encountered: