Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup for reloading the editor after label change #544

Open
JohnPixle opened this issue Aug 13, 2022 · 0 comments
Open

Popup for reloading the editor after label change #544

JohnPixle opened this issue Aug 13, 2022 · 0 comments
Assignees
Labels
Type: Enhancement Improvement of an existing feature

Comments

@JohnPixle
Copy link
Collaborator

JohnPixle commented Aug 13, 2022

I spotted this one, it's a core popup, maybe we can do something similar when the user edits the labels of the SK variables.

Screenshot 2022-08-13 at 21 35 54

This can be helpful in cases where the user is updating:

  • Labels for container spacing presets
  • Labels of SK Global colors
  • Labels of SK Global fonts
  • Labels of Global Shadows

We can show them the popup, and prompt the to refresh the page, in order for the new labels to be visible in the dropdown select.

Here is how it can be:

Screenshot 2022-08-27 at 11 55 10

Let me know if you have any other questions or need any help with that. We can use the native UI and just change the text, no need for a custom popup.

@JohnPixle JohnPixle added the Type: Enhancement Improvement of an existing feature label Aug 13, 2022
@JohnPixle JohnPixle modified the milestones: SK 1.9.3, SK 1.9.4 Aug 13, 2022
@JohnPixle JohnPixle changed the title Popup for reloading the editor Popup for reloading the editor after label change Aug 27, 2022
@JohnPixle JohnPixle modified the milestones: SK 1.9.4, SK 1.9.5, SK 1.9.6 Sep 1, 2022
@JohnPixle JohnPixle modified the milestones: SK 1.9.6, SK 1.9.7, SK 2.0.0 Nov 24, 2022
@JohnPixle JohnPixle modified the milestones: SK 2.0.0, SK 2.1.0 Jan 5, 2023
@JohnPixle JohnPixle removed this from the SK 2.0.3 milestone Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants