-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ament_vendor should be able to use mirror site of git #473
Comments
Upstream CMake had an issue for this: https://gitlab.kitware.com/cmake/cmake/-/issues/22688 . It looks like they closed it in favor of git's Would that work for your use case? |
My original idea is close to the cmake issue. The git config solution is very limited for some very specific cases. If |
In Ros2,
ament_vendor
is mainly used like this:and
VCS_URL https://github.com/assimp/assimp.git
is usually hardcoded.When a mirror site of github is needed to build ros2, it's very difficult to set the mirror site URL unless the source code is modified.
I'm proposing an updated version of macro
ament_vendor
so that it can use env variable (if set) as a prioritized value ofVCS_URL
.As a result, for all the xxxxx_vendor projects, it's not necessary to touch the source code of
VCS_URL
but to set an environmental value ofassimp_vendor_VCS_URL
in my case and use the mirror git site.Any comment? I can create a PR for it.
The text was updated successfully, but these errors were encountered: