-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return -DPIC with pkg-config --cflags alsa
when appropriate
#289
Comments
It's a third-party module ? This flag is set by configure (libtool) and it is not required for the standard alsa-lib apps (except the modules). I would suggest to add |
yeah we're building an alsa plugin for our audio server (CRAS). We currently add -DPIC to our build rules, and I'm wondering if it make sense for this to exposed from pkg-config. |
Some build systems (we are using bazel) do not define -DPIC when compiling position independent objects.
When building a alsa module, if
PIC
is not defined,global.h
requires the presence of thesnd_dlsym_start
symbol, which is absent fromlibasound.so
if alsa itself is built with-DPIC
.alsa-lib/include/global.h
Line 72 in 9447e57
If the
PIC
macro is non-standard I would suggest exposing it via pkg-config so position independent alsa modules can pick up the flag and apply it to the alsa headers appropriately.The text was updated successfully, but these errors were encountered: