Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TermSelector does not export optional parameters to TypeScript #670

Open
mogmarsh opened this issue Sep 12, 2024 · 0 comments
Open

TermSelector does not export optional parameters to TypeScript #670

mogmarsh opened this issue Sep 12, 2024 · 0 comments
Labels
bug Something isn't working typescript Requires understanding TypeScript

Comments

@mogmarsh
Copy link
Contributor

Description of the bug

When using TermSelector in TypeScript, TypeScript wants all parameters to be provided, even though there are default props.

We should rewrite the TermSelector in TypeScript and get rid of the props. Optional params can be specified in TypeScript types with ? and everything should work fine.

Steps To Reproduce

In TypeScript, add a
Only provide the parameters that are required/don't have default values.
The linter will show an error.

Additional Information

No response
@mogmarsh mogmarsh added bug Something isn't working typescript Requires understanding TypeScript labels Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working typescript Requires understanding TypeScript
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mogmarsh