We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This unit test fail on .NET 5.0
var client = ClientExtensions.CreateClient(); const string CacheableResource = "https://code.jquery.com/jquery-3.3.1.slim.min.js"; var response = await client.GetAsync(CacheableResource); var responseFromCache = await client.GetAsync(CacheableResource); Assert.AreEqual(false, response.Headers.GetCacheCowHeader().RetrievedFromCache); Assert.AreEqual(true, responseFromCache.Headers.GetCacheCowHeader().RetrievedFromCache);
The text was updated successfully, but these errors were encountered:
Thanks for reporting. I will look into it but have a feeling is related to #213 which is just fixed during .NET 5.0.
They tried to fix it twice they messed up twice. This will be the 3rd time.
Sorry, something went wrong.
OK, apologies for not being able to look into it.
There is no problem in .NET 5.0, one of the tests do not work which I am looking into.
As for your example your assert is wrong. It fails on first time round in fact, since you expect false while it is null. Change it so you can see:
[Fact] public async Task Simple_Caching_Example_From_Issue263() { var client = ClientExtensions.CreateClient(); const string CacheableResource = "https://code.jquery.com/jquery-3.3.1.slim.min.js"; var response = await client.GetAsync(CacheableResource); var responseFromCache = await client.GetAsync(CacheableResource); Assert.Equal(true, response.Headers.GetCacheCowHeader().DidNotExist); Assert.Equal(true, responseFromCache.Headers.GetCacheCowHeader().RetrievedFromCache); }
aliostad
No branches or pull requests
This unit test fail on .NET 5.0
The text was updated successfully, but these errors were encountered: