Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork with multiple improvements #67

Open
pando85 opened this issue Aug 4, 2022 · 4 comments
Open

Fork with multiple improvements #67

pando85 opened this issue Aug 4, 2022 · 4 comments

Comments

@pando85
Copy link

pando85 commented Aug 4, 2022

Hello guys,
I'm seeing that you have some activity again. I just forked this project two weeks ago because I think that it is fucking amazing.
I forked because I was missing one configuration parameter and a docker image and it was going to be the faster way to solve my problems.

Also, I changed the name to be consistent and writable: you have like supersecrets directories and different notations... and added some basic CI after fixing some tests.

At this point, it is difficult to do a PR to your project but at least I want to share this with you.

I already deployed it in my k8s cluster using Vault operator so I will upload there the descriptors too.

Thank you for your project and if you find something of this useful just ping me back,
Alex

@eranchetz
Copy link
Collaborator

Thanks for the warm compliments 😊
Where can we find your repo? I'll try and work those changes in this one.
Other than us not being very responsive in the past year (apologies) why do you say "it is difficult to do a PR"? I would like to change that so more people can be involved.

@pando85
Copy link
Author

pando85 commented Aug 8, 2022

here: https://github.com/pando85/crow
I mean, it is difficult now for me because there are a lot of changes there (even the name was changed to be consistent) while I thought this repo was not very active and I need to change many things.

I have it deployed in k8s and working pretty find. I really like this software because it is pretty simple.

@swissbuechi
Copy link

swissbuechi commented Sep 2, 2022

I would also love to contribute to this awesome project.
The following changes could be merged from my fork:

  • Production ready vault setup example with azure key vault
  • CI for automatic dependency updates
  • Option to allow a custom logo and color shema
  • Option to disable file upload
  • Option to disable password expiration drop down and set a default of 7 days
  • German translations
  • Option to add a button "display secret" before actually displaying and destroying the secret
    image
  • Optimizations for mobile devices (responsive)

I could create PRs for every feature if you are interessted

@swissbuechi
Copy link

swissbuechi commented Sep 4, 2023

I really like this project and I'm sorry to announce that I did not create all the PR's, but instead created a whole new repository with all my changes...
Feel free to check it out: https://github.com/swissbuechi/one-time-secret
I update all the dependencies on a monthly base.

Thanks for your work. @eranchetz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants