-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*scs.sessionResponseWriter does not implement http.Hijacker #188
Comments
@alexedwards would you kindly accept pull request with a fix to this error? |
I think that the correct fix here is really for the websocket library to start supporting http.ResponseController, which is the modern way of dealing with this. I've pushed a38e822 which makes |
Thank you, works like a charm! |
Hey there! 👋 It seems like we've hit a small roadblock with the scs.sessionResponseWriter wrapper for http.response. Currently, it doesn't implement the http.Hijacker interface. So, when attempting to open a WebSocket, you might encounter the error message: websocket: response does not implement http.Hijacker.
In the past, it were using *scs.bufferedResponseWriter, which conveniently does implement the Hijacker interface.
The text was updated successfully, but these errors were encountered: