Kargo auto promotion not working from warehouse to first stage

[MPritsch]

Hello, not sure if we use kargo wrong or if the mechanics are broken.
We enabled the "enableAutoPromotion" field on the project for our stage "develop". There is only one stage. My expectations are that whenever there is a new Freight added, that it should be automatically promoted to the stage. That does not happen.

The only logs I see in the kargo-controller, when I manually trigger the Freight to promote. No mention when a new freight is detected.

I use kargo version 0.4.2 on an on-premise kubernetes cluster.

Here is my configuration. Is there anything wrong with the promotion mechanic?:

---
apiVersion: kargo.akuity.io/v1alpha1
kind: Project
metadata:
  name: kargo-my-project
spec:
  promotionPolicies:
    - stage: develop
      enableAutoPromotion: true
---
apiVersion: kargo.akuity.io/v1alpha1
kind: Warehouse
metadata:
  name: my-project
  namespace: kargo-my-project
spec:
  subscriptions:
    - git:
        repoURL: https://my.git.repo/url/my-project.git
        allowTags: '^my-tag-regex$'
        commitSelectionStrategy: NewestTag
    - image:
        allowTags: '^my-tag-regex$'
        repoURL: my.docker.repo/url/my-project
        imageSelectionStrategy: NewestBuild
---
apiVersion: kargo.akuity.io/v1alpha1
kind: Stage
metadata:
  name: develop
  namespace: kargo-my-project
spec:
  subscriptions:
    warehouse: my-project
  promotionMechanisms:
    argoCDAppUpdates:
      - appName: develop-my-project
        appNamespace: kube-system
        sourceUpdates:
          - repoURL: https://my.git.repo/url/my-project.git
            updateTargetRevision: true
          - repoURL: https://my.git.repo/url/my-project.git
            kustomize:
              images:
                - image: my.docker.repo/url/my-project
                  useDigest: true

If you need mor information, do not hesitate to ask. Best Regards

[krancour]

@MPritsch this configuration looks ok to me.

The UI doesn't surface errors in Stage reconciliation very well just yet.

I would suggest that you looking at the live state of the develop Stage using kubectl or the Kargo CLI to see if there are any clues in status.error or status.message.

Enabling debug logs on the controller may also help. I'm pretty sure there messages that get logged about auto-promotion eligibility.

[MPritsch]

Okay this helped a lot. It looks like the Project does not have the field "enableAutoPromotion". While it is there in the code, it is missing in the final manifest. ArgoCD shows in the diff that the field should be there, but isn't.
So the question is, who is modifying the Project manifest?
I enabled the debug logs and it tells me there, that auto-promotion is not permitted. Which makes sense when the field is missing.

[krancour]

Oooh... the field is actually autoPromotionEnabled. I'm not sure why Argo CD isn't catching that issue.

[MPritsch]

Oh wow, good eye. Will try tomorrow, but that is surely it

[krancour]

fwiw... it changed from enableAutoPromotion to autoPromotionEnabled at the same time that PromotionPolicy stopped being a top-level CRD and got folded into the Project CRD. The change was because there is more precedent within k8s' own APIs for xxxEnabled than for enabledXXX.

[MPritsch]

Solved, it was 'enableAutoPromotion' but must be 'autoPromotionEnabled'