Health check for Applications with multiple sources

[daftping]

Seems like the health check for Applications with multiple sources is not supported right now.

kargo/internal/controller/stages/health.go

Lines 98 to 100 in 8b6f58a

	// TODO: We should re-evaluate this soon. It may have been fixed in recent
	// versions.
	if len(app.Spec.Sources) > 0 {

Does anybody know what Argo CD issue this TODO is referring to?

  health:
    status: Unknown
    issues:
      - bugs in Argo CD currently prevent a comprehensive assessment of the
        health of multi-source Application "test-app-helm" in
        namespace "argo-cd"

[krancour]

First, I apologize for not including URLs for specific issues.

My recollection is that the Status.Sync.Revisions field was only ever reporting the revision for one source, even when there were multiples. This made it impossible to assert that the Application was up to date with respect to commits or charts in the Stage's current Freight.

The issue in Argo CD that seems to describe this most accurately, and has long since been resolved, is argoproj/argo-cd#13859.

Oddly, I wrote "bugs in Argo CD" error message before that issue was opened.

Possibilities:

1. That issue is a duplicate of an earlier one that I cannot find now
2. I knew about the issue before anyone else and failed to report it 😓
3. I saw the large volume of bugs related to multi-source and concluded it wasn't stable and that we should just give it time. Multi-source was brand new at the time I committed that error message.

No matter how you slice it, I really should have included more detail.

I will convert this discussion to an issue to remind myself to revisit this.

Thank you for raising this @daftping !

[krancour]

Fixed in v0.9.0.