Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert Failure to exception when using Ask<object> #7286

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

convert Failure to exception when using Ask<object> #7286

wants to merge 3 commits into from

Conversation

ondravondra
Copy link
Contributor

close #7254

@Aaronontheweb
Copy link
Member

Thanks for the PR - looks like this broke some tests

@ondravondra
Copy link
Contributor Author

It seems that the framework relies on this behavior.
For example, test Inbox_Receive_will_timeout_gracefully_if_timeout_is_already_expired uses Akka.Actor.Inbox.Receive that calls Ask<object> and expects the result to be Status.Failure.
A bit of a pickle innit.

@Aaronontheweb
Copy link
Member

It seems that the framework relies on this behavior. For example, test Inbox_Receive_will_timeout_gracefully_if_timeout_is_already_expired uses Akka.Actor.Inbox.Receive that calls Ask<object> and expects the result to be Status.Failure. A bit of a pickle innit.

Probably just poor test design - at least that was my gut feeling when I looked at this PR. I'll give it another look when I can

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ask<object> will not throw exception when the response is Status.Failure
2 participants
@ondravondra @Aaronontheweb