Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance-improvement: Speed up de9im pattern matching #37

Open
Croydon-Brixton opened this issue Mar 3, 2021 · 0 comments
Open

Performance-improvement: Speed up de9im pattern matching #37

Croydon-Brixton opened this issue Mar 3, 2021 · 0 comments
Labels
concerns: GeoGraph kind: enhancement New feature or request kind: performance performance improvement

Comments

@Croydon-Brixton
Copy link
Collaborator

Croydon-Brixton commented Mar 3, 2021

I feel like there has to be a way to make this much more efficient, maybe through stuff like numba or Cython, but that's something to leave for later.

Originally posted by @herbiebradley in #28 (comment)

Further info:
Side note: when searching for what the relate function does we came to this: https://github.com/libgeos/geos/blob/186bbd32fbf07d8b5d419cdfd64c14e2270a418a/src/geom/IntersectionMatrix.cpp#L89 which are the functions which a lot of Shapely stuff calls.

Overall, we haven't concentrated on this part much bc the string comparison is much faster than the overlap computations and rtree query so the overall speedup in the function would be only around 5%.

@Croydon-Brixton Croydon-Brixton changed the title Speed up de9im pattern matching Performance-improvement: Speed up de9im pattern matching Mar 3, 2021
@Croydon-Brixton Croydon-Brixton added the kind: performance performance improvement label Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
concerns: GeoGraph kind: enhancement New feature or request kind: performance performance improvement
Projects
None yet
Development

No branches or pull requests

1 participant