Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client_test could be more generic #204

Open
infinity0 opened this issue Oct 4, 2015 · 4 comments
Open

client_test could be more generic #204

infinity0 opened this issue Oct 4, 2015 · 4 comments

Comments

@infinity0
Copy link
Contributor

I'm building pond without the GUI (-tags nogui) but then client_test fails to build with undefined: FileOpen. It seems very specific to the GUI, maybe some parts could be applied to the CLI too?
@burdges
Copy link
Contributor

burdges commented Oct 4, 2015

A partial fix was merged here : #165

@infinity0
Copy link
Contributor Author

Ah, I just need to set nogtk instead of nogui, looks like it works. But then the built client thinks that haveGUI = true; I'll send in a patch.

@burdges
Copy link
Contributor

burdges commented Oct 6, 2015

Any client actually built for usage only from the command command line should still use nogui. The abstract GUI built by nogtk is needed for testing, but not for CLI operation.

@infinity0
Copy link
Contributor Author

But it's quite annoying to have to build it twice, once for running and once for tests. That's not a normal workflow for doing builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@infinity0 @burdges