-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
History lib doesn't account for some types of changes #679
Comments
The scope of aframe-watcher is to update only existing entities because it's based on the entity id. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem:
I'm trying to use inspector with aframe-watcher to update my local files with changes I make with AFrame inspector. However, I noticed that some types of changes don't get written:
Potential cause:
From my best understanding, the way it works is when a change in inspector happens, it fires an "entityupdate" event. This is listened to in the history.js file and recorded. When the save button is pressed, it makes a request to aframe-watcher with the contents of what has been recorded in AFRAME.INSPECTOR.history.updates.
It seems like the "entityupdate" event is not fired when these additions / removals are done in inspector.
The text was updated successfully, but these errors were encountered: