Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop jQuery dependency #72

Open
BoPeng opened this issue Jan 5, 2021 · 5 comments · May be fixed by #73
Open

drop jQuery dependency #72

BoPeng opened this issue Jan 5, 2021 · 5 comments · May be fixed by #73

Comments

@BoPeng
Copy link

BoPeng commented Jan 5, 2021

bootstrap5 beta is out and the biggest change would be the drop of jquery dependency.

I just briefly tested bootstrap-toc on my website and it appears to be working properly as long as I load bootstrap5 and jquery. I am not quite sure if it is worthwhile to stop using jquery in bootstrap-toc but it would be nice if someone tries to tackle it.
@afeld
Copy link
Owner

afeld commented Jan 5, 2021

Ah, good to know. #16 would probably be a good way to future-proof against that problem.

@afeld
Copy link
Owner

afeld commented Jan 5, 2021

Would love some help on that if interested!

@BoPeng
Copy link
Author

BoPeng commented Jan 5, 2021

Had a look at #16. My "working properly" might be wrong since scrollspy might not be working properly. Anyway, I think dropping dependency on jquery is more important than dropping dependency on bootstrap.

@afeld afeld changed the title bootstrap 5 compatibility drop jQuery dependency Jan 5, 2021
@afeld
Copy link
Owner

afeld commented Jan 5, 2021

Got it. Re-titled to reflect that. Seems very doable, though not sure when I will get to it. Pull request welcome!

@Pustur
Copy link

Pustur commented Jan 8, 2021

Hey,

I started working on this feature, I was almost done when I noticed that I made a mistake.
The $scope option can contain more than one element in this library, but my implementation assumes that it's a single element.

I'm pretty tired now to fix it (and I don't know if/when I'll want to continue it), but I'll link my fork so you can maybe take it and improve it, and hopefully finish this transition.

https://github.com/Pustur/bootstrap-toc/tree/remove-jquery

I'm available if you have any questions.

PS: Commits are pretty messy, but I left them separated to better show the steps I took.

This was referenced Jan 15, 2021
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove jQuery dependency
3 participants
@afeld @BoPeng @Pustur