Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to use plugins without compiling them into root CLI #73

Open
ankithans opened this issue Jun 18, 2021 · 2 comments
Open

Ability to use plugins without compiling them into root CLI #73

ankithans opened this issue Jun 18, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@ankithans
Copy link
Member

The ability to run the CLI plugin with the binary, can be done by keeping the registry for supported plugins
#37 provides somewhat fair example to this

@ankithans ankithans added the enhancement New feature or request label Jun 18, 2021
@wtrocki
Copy link
Contributor

wtrocki commented Jun 18, 2021

Note that this is not full blown registry - just code to call binary that is either:

  • installed in the system
  • documented to be installed and failover if not
  • There is no need to have list/install commands etc.

Copying exact comment as link brings us to the entire PR:

Calling external CLI is a very cool although a commonly resolved problem in the golang ecosystem.
I do not want to steal cool feature from you and we can keep this as capability, but I did not think that people will use charmil for that where you can have this:

https://github.com/kubernetes/kubectl/blob/master/pkg/cmd/plugin/plugin.go

https://github.com/openshift-online/ocm-cli/blob/master/pkg/plugin/plugin.go

https://github.com/openshift/odo/blob/main/pkg/odo/cli/plugins/plugin_handler.go

@wtrocki
Copy link
Contributor

wtrocki commented Aug 9, 2021

This is epic that is outside the scope of the GSOC for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants