Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proper packaging? #16

Open
drzraf opened this issue Oct 24, 2024 · 1 comment
Open

proper packaging? #16

drzraf opened this issue Oct 24, 2024 · 1 comment

Comments

@drzraf
Copy link

drzraf commented Oct 24, 2024

Follow-up of ADSBexchange/feedclient#16 which applies as well to the present master branch (which sounds like a fork but started as a copy, isn't?)

  • apt-gets = Depends
  • git clone = .deb
  • compile readsb: Should be another .deb
  • mlat-client: Should be a pip / pipx
  • adduser & systemd services => part of .deb
  • uuid generation => part of pre-inst script
  • whiptail / PORT selection / ... => debconf
  • adsblol-feed.sh => converted to proper .service file (ideally, part of the readsb .deb)
  • package only bundles a handful of files, clear configuration in /etc + an apparmor profile, all cleanly build with real idempotent install/uninstall the Debian way => Neither a blackbox, nor a mess, consistent and reproducible, and almost a one-command process

Does it sound desirable from a long-term maintenance perspective?

@wiedehopf
Copy link

mlat-client having a non-deprecated way to build would be nice.
(and i find the whole python build stuff very confusing when i tried touching it)

readsb being a deb is an issue unless you make the package / binary name adsb.lol specific.
different projects don't want their installed binary messed with by another project.

Considering that you'd still build the debs during install, you still have a shell script users need to run.
It installs more stuff to build the debs (that's a minor drawkback i suppose).

Dealing with debian packaging sounds like work from a maintenance perspective actually.

Really making sure this works after lots of changes would be a lot of work.
The number of users who care about this and don't just use one of the docker containers is likely pretty small.
And for 99% of users it's just as much of a black box after the proposed changes.

git clone = .deb
Are you suggesting to actually have a deb for download?
With all the architectures / system versions that sounds like a nightmare.

I get the intent, but i'm doubting the actual benefit.

One note, there is this linked in the readme: https://github.com/adsblol/feed?tab=readme-ov-file#manual-feeding-with-readsb-and-mlat-client
So this is an alternative for people who don't want to run the scripts and don't want to run docker stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants