Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate VDR Using Github Actions #15

Merged
merged 24 commits into from
May 28, 2024
Merged

Generate VDR Using Github Actions #15

merged 24 commits into from
May 28, 2024

Conversation

Scanteianu
Copy link
Contributor

@Scanteianu Scanteianu commented May 10, 2024 •
edited
Loading

Run pipeline to generate the VDR from Github Actions.
Publishes both the vdr and also the data directory with supporting artifacts.

Resolves #7

@Scanteianu Scanteianu marked this pull request as ready for review May 10, 2024 12:50
@Scanteianu Scanteianu changed the title Vdr generation gh action Generate VDR Using Github Actions May 10, 2024
@karianna karianna requested a review from gdams May 11, 2024 23:08
gdams
gdams requested changes May 13, 2024
View reviewed changes
.github/workflows/vdr-creation.yml Outdated Show resolved Hide resolved
.github/workflows/vdr-creation.yml Outdated Show resolved Hide resolved
.github/workflows/vdr-creation.yml Outdated Show resolved Hide resolved
.github/workflows/vdr-creation.yml Outdated Show resolved Hide resolved
.github/workflows/vdr-creation.yml Outdated Show resolved Hide resolved
@Scanteianu Scanteianu requested a review from gdams May 13, 2024 16:35
gdams
gdams requested changes May 14, 2024
View reviewed changes
.github/workflows/vdr-creation.yml Outdated Show resolved Hide resolved
@Scanteianu Scanteianu requested a review from gdams May 14, 2024 15:13
steelhead31
steelhead31 approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gdams gdams merged commit 777a161 into adoptium:main May 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steelhead31 steelhead31 steelhead31 approved these changes

@gdams gdams gdams approved these changes

@karianna karianna karianna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generate VDR using Github Actions
4 participants
@Scanteianu @karianna @gdams @steelhead31