-
-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ReproducibleBuilds.md with cygwin details #3973
Open
judovana
wants to merge
26
commits into
adoptium:master
Choose a base branch
from
judovana:comparableReadmeUpdate
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
Issues that request updates to our documentation
label
Oct 4, 2024
@judovana linter failures |
nice! ty! |
judovana
force-pushed
the
comparableReadmeUpdate
branch
2 times, most recently
from
October 7, 2024 11:36
51b4092
to
b4d4b09
Compare
judovana
force-pushed
the
comparableReadmeUpdate
branch
from
October 7, 2024 11:39
b4d4b09
to
7f9cbf9
Compare
goodnow. Thanx again! |
karianna
requested changes
Oct 7, 2024
Co-authored-by: Martijn Verburg <[email protected]>
Co-authored-by: Martijn Verburg <[email protected]>
Co-authored-by: Martijn Verburg <[email protected]>
Co-authored-by: Martijn Verburg <[email protected]>
Co-authored-by: Martijn Verburg <[email protected]>
Co-authored-by: Martijn Verburg <[email protected]>
Co-authored-by: Martijn Verburg <[email protected]>
Co-authored-by: Martijn Verburg <[email protected]>
Co-authored-by: Martijn Verburg <[email protected]>
karianna
reviewed
Oct 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments to go
karianna
approved these changes
Oct 10, 2024
TYVM! @andrew-m-leonard wdyt? |
judovana
force-pushed
the
comparableReadmeUpdate
branch
from
October 25, 2024 10:58
f3ff0ad
to
146fb5c
Compare
@andrew-m-leonard ping please? |
andrew-m-leonard
requested changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few notes I learned when launched through cygwin.