Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Installer Files For JDK8, JDK11, JDK17, JDK21 & JDK22 for April CPU #862

Merged
merged 10 commits into from
Apr 24, 2024

Conversation

steelhead31
Copy link
Contributor

This PR updates the installer files, so that installers for the April CPU can be published.

Note that for JDK22, s390x code has been removed, as this will require a follow up change to allow for the bump in version number for the s390x specific JDK patch.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.

If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.

If the code freeze is over you can remove this block by commenting /thaw.

Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@andrew-m-leonard andrew-m-leonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@jerboaa
Copy link
Contributor

jerboaa commented Apr 23, 2024

@steelhead31 There are some test failures on JDK 11. Please check.

@steelhead31
Copy link
Contributor Author

Failing checks are related to unpublished platforms, will ensure all checks are green before merging.

@steelhead31
Copy link
Contributor Author

@steelhead31 There are some test failures on JDK 11. Please check.

Theres likely a few issues with checksums and filenames, I'll check them all thoroughly..

@steelhead31
Copy link
Contributor Author

All checked, remaining 8 & 11 failures due to unpublished platforms ( Arm & Alpine ) :)

@steelhead31
Copy link
Contributor Author

/merge

Copy link

Approval to merge during the lockdown cycle

Please can two Adoptium PMC members comment /approve?

@tellison
Copy link
Contributor

/approve

Copy link
Contributor

@tellison tellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trust that the hashes are good

@sxa
Copy link
Member

sxa commented Apr 23, 2024

/approve

@github-actions github-actions bot dismissed their stale review April 23, 2024 20:55

Thank you @tellison and @sxa for your approvals, this pull request is now approved to merge during release.

@steelhead31 steelhead31 merged commit 0fdd792 into adoptium:master Apr 24, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants