-
-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ubuntu 24.04 Noble #534
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
How are the additional tags for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rejecting this for now since this is currently asking to add a not-yet-released distribution to the list of docker images that we provide. This would need to have a PMC discussion before going live (and for 24.04 to be available as an official socket image which won't happen prior to the 25th April release date), especially since we're in the middle of a release cycle at the moment. I do have a separate issue to support 24.04 at various other parts of the project so thanks for raising this request here too!
Hi! I noticed that Noble images are available now (pushed 10 hours ago): https://hub.docker.com/_/ubuntu/tags
|
@poikilotherm can you please also update https://github.com/adoptium/containers/blob/main/dockerhub_doc_config_update.sh#L42 |
@sxa Ubuntu 24.04 noble is released now. |
@sxa Did the PMC get a chance to meet and approve this version? |
As suggested by @gdams Co-authored-by: George Adams <[email protected]>
Hi there @sxa @gdams, sorry for not being responsive. Was on a long vacation. I updated this branch with the changes from I see lots of activity in lots of places at |
As suggested by @gdams
No problem - I'm just back from about 2½ weeks too!
👍🏻
Yep they'll need to be analysed and understood/fixed before we'd be confident shipping this. adoptium/infrastructure#3501 is where most of the triage/analysis is currently being done, although there seems to be quite a mix of failing tests there. |
@sxa all tests pass now |
The PMC intends to update this as part of the July PSU updates. This PR is now good to be merged but the manifest won't be updated until July 16th |
I tested the generated Dockerfiles locally with my application, seems to work. Pushed it to GHCR for testing https://github.com/users/poikilotherm/packages/container/package/eclipse-temurin
Closes #532
I noticed that with Ubuntu 24.04 they added a default "ubuntu" user. Do you want to keep that one around or should it be deleted?