Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ubuntu 24.04 Noble #534

Merged
merged 7 commits into from
Jul 10, 2024
Merged

Add Ubuntu 24.04 Noble #534

merged 7 commits into from
Jul 10, 2024

Conversation

poikilotherm
Copy link
Contributor

@poikilotherm poikilotherm commented Apr 19, 2024

I tested the generated Dockerfiles locally with my application, seems to work. Pushed it to GHCR for testing https://github.com/users/poikilotherm/packages/container/package/eclipse-temurin

Closes #532

I noticed that with Ubuntu 24.04 they added a default "ubuntu" user. Do you want to keep that one around or should it be deleted?

@karianna karianna requested a review from sxa April 19, 2024 07:45
Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@poikilotherm
Copy link
Contributor Author

poikilotherm commented Apr 19, 2024

How are the additional tags for 17-jre and others determined to be applied to which image builds? I wouldn't want anyone start using a not-yet-released version of Ubuntu and maybe some people rely on 17-jre to stay on the same OS version for some time...

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rejecting this for now since this is currently asking to add a not-yet-released distribution to the list of docker images that we provide. This would need to have a PMC discussion before going live (and for 24.04 to be available as an official socket image which won't happen prior to the 25th April release date), especially since we're in the middle of a release cycle at the moment. I do have a separate issue to support 24.04 at various other parts of the project so thanks for raising this request here too!

@alexander-yakushev
Copy link

Hi! I noticed that Noble images are available now (pushed 10 hours ago): https://hub.docker.com/_/ubuntu/tags

root@240f07d544d6:/# cat /etc/issue
Ubuntu 24.04 LTS \n \l

@gdams
Copy link
Member

gdams commented Apr 29, 2024

@poikilotherm can you please also update https://github.com/adoptium/containers/blob/main/dockerhub_doc_config_update.sh#L42

@MichalKoziorowski-TomTom

@sxa Ubuntu 24.04 noble is released now.

@karianna
Copy link
Contributor

@sxa Did the PMC get a chance to meet and approve this version?

@poikilotherm
Copy link
Contributor Author

Hi there @sxa @gdams, sorry for not being responsive. Was on a long vacation.

I updated this branch with the changes from main and commited the suggestion by @gdams.

I see lots of activity in lots of places at adoptium/infrastructure. I suppose merging this one will be put on hold until the failing tests are sorted out?

@sxa
Copy link
Member

sxa commented Jun 7, 2024

Hi there @sxa @gdams, sorry for not being responsive. Was on a long vacation.

No problem - I'm just back from about 2½ weeks too!

I updated this branch with the changes from main and commited the suggestion by @gdams.

👍🏻

I see lots of activity in lots of places at adoptium/infrastructure. I suppose merging this one will be put on hold until the failing tests are sorted out?

Yep they'll need to be analysed and understood/fixed before we'd be confident shipping this. adoptium/infrastructure#3501 is where most of the triage/analysis is currently being done, although there seems to be quite a mix of failing tests there.

@karianna karianna requested a review from sxa July 1, 2024 01:10
@karianna
Copy link
Contributor

karianna commented Jul 1, 2024

@sxa all tests pass now

@gdams
Copy link
Member

gdams commented Jul 3, 2024

The PMC intends to update this as part of the July PSU updates. This PR is now good to be merged but the manifest won't be updated until July 16th

@gdams gdams merged commit d762761 into adoptium:main Jul 10, 2024
66 checks passed
@poikilotherm poikilotherm deleted the 532-add-noble branch July 10, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ubuntu Noble flavor?
6 participants