Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

riscv64 builds (or any using docker image tag or digest) broken #1082

Closed
andrew-m-leonard opened this issue Jul 23, 2024 · 1 comment · Fixed by #1083
Closed

riscv64 builds (or any using docker image tag or digest) broken #1082

andrew-m-leonard opened this issue Jul 23, 2024 · 1 comment · Fixed by #1083
Labels
buildbreak High priority issues that cause build breaks in jenkins or build scripts cross-compile docker linux

Comments

@andrew-m-leonard
Copy link
Contributor

PR: #1076 added a patch to tag using the docker_image to handle scenario when using a dockerRegistry. However, it searches the image ls using the docker_image, which may contain a :tag or @digest, which will not match...
eg: https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk23/job/jdk23-linux-riscv64-temurin/9/console

10:11:32  + docker image ls
10:11:32  + grep adoptopenjdk/ubuntu2004_build_image:linux-riscv64
10:11:32  + head -n1
10:11:32  + awk {print $1}
[Pipeline] sh
10:11:34  + docker tag  adoptopenjdk/ubuntu2004_build_image:linux-riscv64
10:11:34  Error parsing reference: "" is not a valid repository/tag: invalid reference format

docker ls returns the "Repository", you can't locate the entry you need from that list using the plain DOCKER_IMAGE string

@sxa
Copy link
Member

sxa commented Jul 23, 2024

Took me a bit of time to understand the specific problem here, but for historic reference it is because docker image ls gives lines like this:

adoptopenjdk/ubuntu2004_build_image           linux-riscv64   d7f86236b5fd   5 days ago       3.01GB

which the grep with the colon separation between image and tag will not pick up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
buildbreak High priority issues that cause build breaks in jenkins or build scripts cross-compile docker linux
Projects
None yet
2 participants