-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change generated core files current dir to reportdir #5389
Conversation
Grinder Test: https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/41379/consoleFull
But please let me know if we need to run other target tests as well. |
@LongyuZhang would you please kind review, thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The purpose for this PR is able to archive the dump file. To test the PR:
- rerun the original build to reproduce the dump process
- change to your branch to see if dump process can still be generated (checkbox Keep_Workspace and Keep_ReportDir so you can reserve the machine to go back and check), then check if the core file is saved in the target folder as expected.
- If the core file is saved in the target folder, I suppose it will be uploaded into the build artifactory automatically.
This is not the desired reportdir we wanted. see below comment.. |
a3b9447
to
799e0c5
Compare
Running parallelly on 5 machines, and one machine has the dump core files generated now:
|
This is to change the directory of core files to the correct one Related to issue: adoptium#5373 Signed-off-by: sophiaxu0424 <[email protected]>
Verified that the with the latest change, the parent and child tests could also generate dump files in the correct
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is to change the directory of core files to the correct one
Related to issue: #5373
Signed-off-by: sophiaxu0424 [email protected]