Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work out best way to handle reading large SysEx messages #4

Open
kevinjwalters opened this issue Feb 26, 2019 · 3 comments
Open

Work out best way to handle reading large SysEx messages #4

kevinjwalters opened this issue Feb 26, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@kevinjwalters
Copy link

kevinjwalters commented Feb 26, 2019

Not of immediate concern but SysEx can be very big so need to work out what can be done here after first implementation for #3 , particularly taking into account memory limitations of various hardware CircuitPython runs on.

@kevinjwalters
Copy link
Author

#3 will now at least parse past them although this may take a while if they are huge given the default read buffer size of 30.

@kevinjwalters
Copy link
Author

There's some interest expressed in adafruit/circuitpython#2245 (comment) in reading SysEx messages. It also mentions a common practice of a "2 byte" (14bit?) length field.

Worth looking at design patterns for handling rare large messages - this might be a different approach to the regular small MIDI messages.

@kattni kattni added the enhancement New feature or request label May 4, 2020
@kevinjwalters
Copy link
Author

Winterbloom SmolMIDI supports SysEx: https://github.com/wntrblm/Winterbloom_SmolMIDI#system-exclusive-messages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants