Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Human readable time formatter; 'duration' vs. 'time' labels #63

Open
jahshuwaa opened this issue May 28, 2021 · 0 comments
Open

Human readable time formatter; 'duration' vs. 'time' labels #63

jahshuwaa opened this issue May 28, 2021 · 0 comments

Comments

@jahshuwaa
Copy link

For the "human readable time" duration formatter could it output H:mm:ss ?
Also suggest changing the duration labels throughout Harry Plotter from "time" to "duration"
"Average Plot Duration", vs. "Average Plot Time"
"Phase 1 Duration"
"Copy Duration"
etc.

It's a longer label yes but when I see "time" I'm primed for the data to be a moment in time, not a duration of time.
"Start Time" and "End Time" would be moments in time :-)

Last Plot Duration 10:36:39 (38199s)
or
Last Plot Duration 10h 36m 39s (38199s)

use perhaps org.apache.commons.lang3.time.DurationFormatUtils ?
DurationFormatUtils.formatDuration(millis, "H:mm:ss", true);
or
DurationFormatUtils.formatDuration(millis, "H'h' mm'm' ss's'", true);

at com.abysl.harryplotter.util UtilExtensions.kt
fun Duration.formatted(): String {}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant