Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide how to handle logging in public class methods that don't have access to a logger #1652

Open
lawrence-forooghian opened this issue Apr 13, 2023 · 1 comment
Labels
enhancement New feature or improved functionality.
Milestone

Comments

@lawrence-forooghian
Copy link
Collaborator

lawrence-forooghian commented Apr 13, 2023

We've introduced a +[ARTInternalLogHandler classMethodLogger], to be used in this situation. Currently it creates a logger whose log level is .none, so it doesn't emit any log messages. Let's decide what the right thing to do is here.

Also, if we do end up deciding not to log any messages, then might it be better to allow nil loggers throughout the codebase instead of having to create a no-op logger?

┆Issue is synchronized with this Jira Task by Unito

@lawrence-forooghian lawrence-forooghian added this to the Logging milestone Apr 13, 2023
@sync-by-unito
Copy link

sync-by-unito bot commented Apr 13, 2023

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3525

@umair-ably umair-ably added the enhancement New feature or improved functionality. label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improved functionality.
Development

No branches or pull requests

2 participants