New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove redundant computation from Jacobi test #43

Open

omershlo opened this issue Oct 14, 2020 · 0 comments

Labels

good first issue

Contributor

omershlo commented Oct 14, 2020 •

edited

Loading

class/src/primitives/cl_dl_lcm.rs

Lines 541 to 543 in 2a8fa3b

    
           fn two_over(n: &BigInt) -> i8 { 
        
               if n.mod_floor(&BigInt::from(8)) == BigInt::one() 
        
                   || n.mod_floor(&BigInt::from(8)) == BigInt::from(7)

modulo is computed twice.

omershlo added the good first issue label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment