Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize compose and reduce #22

Open
omershlo opened this issue Sep 12, 2019 · 0 comments
Open

optimize compose and reduce #22

omershlo opened this issue Sep 12, 2019 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers pari

Comments

@omershlo
Copy link
Contributor

based on remark from reviewers:

It seems to us that you are using some unoptimized functions for composition and reduction that we wrote mainly for experimenting. For example the reduce function in https://github.com/KZen-networks/class-groups/blob/master/src/lib.rs outputs the reduction matrix which is not needed for the encryption scheme. Using directly the gmul pari C function will probably be more efficient to compute composition of two forms followed by a reduction.

Basically - gmul should be used directly in compose function

@omershlo omershlo added enhancement New feature or request good first issue Good for newcomers labels Sep 12, 2019
@omershlo omershlo added the pari label Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers pari
Projects
None yet
Development

No branches or pull requests

1 participant