-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically verify transactions in blocks when the same transaction is already in the mempool #5674
Open
Comments
This was referenced Nov 21, 2022
teor2345
added
I-slow
Problems with performance or responsiveness
P-Optional ✨
A-rpc
Area: Remote Procedure Call interfaces
labels
Nov 21, 2022
teor2345
changed the title
Automatically verify transactions that are already in the mempool
Automatically verify transactions in blocks when the same transaction is already in the mempool
Apr 4, 2023
17 tasks
This only applies to non-contextual checks, right? Otherwise you have the following condition:
The same can happen for nullifiers, and for any other contextual check (e.g. mempool transactions can expire, etc.) It's fine as long as mining |
Ah, it sounds as though that was considered in #5376 (comment) . |
7 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Motivation
Miners need RPCs and verification to be fast, to improve profits.
When Zebra has already verified a transaction in the mempool, we know it will be valid in a block. (The mempool checks are stricter than the block transaction checks.)
So we can save time by automatically approving any block transaction verify requests that match a transaction already in the mempool.
Security
We will need to test that the mempool checks are stricter than the block transaction checks. Otherwise, we could approve invalid blocks.
The text was updated successfully, but these errors were encountered: