Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share commitments should be vectors #129

Open
upbqdn opened this issue Aug 9, 2021 · 0 comments
Open

Share commitments should be vectors #129

upbqdn opened this issue Aug 9, 2021 · 0 comments
Assignees
Labels
bug Something isn't working frost

Comments

@upbqdn
Copy link
Member

upbqdn commented Aug 9, 2021

Description

The field share_commitment

share_commitment: BTreeMap<ParticipantId, Commitment>,

should contain a vector of commitments instead of just one commitment.

In our tests, we also consider only the zeroth commitment, which is a commitment to the shared secret, and we don't consider the remaining commitments:

Commitment::from(share.share.commitment.0[0].clone()),

Rationale

The field share_commitment, as defined above, should represent the struct ShareCommitment in the FROST implementation:

pub struct ShareCommitment(pub(crate) Vec<Commitment>);

The struct ShareCommitment is a vector, and represents a public commitment C⃗i as defined in step 3, Round 1 of Figure 1 of the FROST paper. This public commitment contains commitments to the individual coefficients of the secret polynomial.

@upbqdn upbqdn added frost bug Something isn't working labels Aug 9, 2021
@upbqdn upbqdn self-assigned this Aug 9, 2021
@ftm1000 ftm1000 added frost and removed frost labels Feb 10, 2022
@ftm1000 ftm1000 assigned dconnolly and chelseakomlo and unassigned upbqdn Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frost
Projects
None yet
Development

No branches or pull requests

4 participants