Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oj dependency causes JSON parsing surprises #46

Open
fastjames opened this issue Jan 3, 2019 · 0 comments
Open

Oj dependency causes JSON parsing surprises #46

fastjames opened this issue Jan 3, 2019 · 0 comments

Comments

@fastjames
Copy link
Contributor

We recently added this gem to a rails app that we are building, and we were surprised to see some behavior changes in other parts of our app. Because of the oj dependency here, we observed a change in how our app handled encoding and dumping of Infinity values. We were able to work around it by calling MultiJson.use but it makes me wonder if MultiJson might be a better fit for this gem. I couldn't find anything in the repo that indicated the specific reason for oj being here, so if we used MultiJson instead the library user could choose that or some other JSON parser. What do you think about this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant